fix(telegram): sanitize download filenames - #5
Merged
Conversation
There was a problem hiding this comment.
🟢 Ready to approve
The sanitization logic is applied at the right boundary (path construction), and the added unit tests cover the intended regression scenarios without introducing behavioral risks elsewhere.
This review doesn't count toward merge requirements. Sign up for the private preview to control whether Copilot approvals count.
Pull request overview
This PR hardens the local download-path generation in internal/telegram by sanitizing both the internal registry key and Telegram-provided filenames, aiming to prevent invalid/unsafe filenames (notably on Windows) and to avoid path-related surprises.
Changes:
- Sanitize both halves of the generated download filename (registry key + Telegram filename) before joining into the storage directory path.
- Add
sanitizeDownloadFileNamehelper to replace Windows-invalid/control characters and trim trailing dots/spaces. - Add a small regression test suite covering photo keys and unsafe document names.
File summaries
| File | Description |
|---|---|
| internal/telegram/files.go | Applies centralized filename sanitization when generating the download target path; adds the sanitization helper. |
| internal/telegram/files_test.go | Adds regression tests to ensure expected sanitization behavior for common/unsafe inputs. |
Review details
- Files reviewed: 2/2 changed files
- Comments generated: 0
- Review effort level: Lite
We're testing this review assessment. Please use 👍 or 👎 to tell us if it's correct.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Testing