Enumerations from Common Access Model#1
Conversation
torstees
left a comment
There was a problem hiding this comment.
This isn't in these files, but the contents of "source_nodes" should be inside source_nodes, not at the same level, which is what I see here Each of those "-" should be indented by an additional 2 spaces or whatever indentation you are using. You should compare it to the original here. It might be worth doing a similar comparison for others to make sure there aren't any other glitches that are happening with the extraction.
torstees
left a comment
There was a problem hiding this comment.
I suggest we remove the tests and the "test target" from the just file. See my inline comments.
There was a problem hiding this comment.
I was thinking we discussed removing these files in tests/data/valid/*.yaml since they were based on the dummy model that was created during the copier execution. Why don't we delete these, or possibly remove the test target from the justfile so that we don't unintentionally send someone down a rabbit whole of trying to fix irrelevant tests.
There was a problem hiding this comment.
Removed the valid tests files.
| deploy: site | ||
| mkd-gh-deploy | ||
|
|
||
| # Run all tests |
There was a problem hiding this comment.
you could remove these 3 lines (and comment) to remove the test target from just which would prevent anyone from accidentally trying to run them. There isn't anything LML provides to test those enums, as far as I'm aware.
There was a problem hiding this comment.
Removed those three lines with comment.
Removed deploy target from deployment group in justfile.
No description provided.