Skip to content

Enumerations from Common Access Model#1

Open
yelenacox wants to merge 8 commits into
mainfrom
yc/fd-3626
Open

Enumerations from Common Access Model#1
yelenacox wants to merge 8 commits into
mainfrom
yc/fd-3626

Conversation

@yelenacox
Copy link
Copy Markdown
Collaborator

No description provided.

@yelenacox yelenacox requested a review from torstees May 20, 2026 16:22
Copy link
Copy Markdown
Collaborator

@torstees torstees left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This isn't in these files, but the contents of "source_nodes" should be inside source_nodes, not at the same level, which is what I see here Each of those "-" should be indented by an additional 2 spaces or whatever indentation you are using. You should compare it to the original here. It might be worth doing a similar comparison for others to make sure there aren't any other glitches that are happening with the extraction.

Copy link
Copy Markdown
Collaborator

@torstees torstees left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I suggest we remove the tests and the "test target" from the just file. See my inline comments.

Comment thread tests/data/valid/Person-001.yaml Outdated
Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I was thinking we discussed removing these files in tests/data/valid/*.yaml since they were based on the dummy model that was created during the copier execution. Why don't we delete these, or possibly remove the test target from the justfile so that we don't unintentionally send someone down a rabbit whole of trying to fix irrelevant tests.

Copy link
Copy Markdown
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Removed the valid tests files.

Comment thread justfile Outdated
deploy: site
mkd-gh-deploy

# Run all tests
Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

you could remove these 3 lines (and comment) to remove the test target from just which would prevent anyone from accidentally trying to run them. There isn't anything LML provides to test those enums, as far as I'm aware.

Copy link
Copy Markdown
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Removed those three lines with comment.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants