✨ POC aadsc, access WIP, fhir

[brendagutman]

Pull Request Name

Please include a summary of the change and which issue is fixed. Please also
include relevant motivation and context. List any dependencies that are
required for this change.

Closes (issue identifier)

Type of change

Please delete options that are not relevant.

• Bug fix (non-breaking change which fixes an issue)
• New feature (non-breaking change which adds functionality)
• Breaking change (fix or feature that would cause existing functionality
  to not work as expected)
• This change requires a documentation update

How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Provide
instructions so we can reproduce. Please also list any relevant details for
your test configuration

• To test the models contain valid valid refs I ran dbt compile locally.
  • Files pertaining to this PR passed, others did not because of the nature of this sandbox environment. Ex: Not all seeds are being pushed to github atm which is expected.

Test Configuration:

• Environment: Local
• Test files: None

Checklist

Please check all of the items below before merging this pull request. If an
item in the list below does not need to be completed, please indicate the
reason why.

• I ensured that all tables have proper source and ref definitions
  • Not possible at this stage
• I Defined {{ config(schema=[schema name], tags = [list, of, tags]) }} at
  the start of each script
  • I added the schema and tags to the dbt_profiles.yml
• I have performed a self-review of my own code
• I have checked my code and corrected any misspellings
• [ SKIP] I have commented my code, particularly in hard-to-understand areas
• [SKIP] I have made corresponding changes to the documentation
  • Once we get through the pilot studies documentation can be updated.
• [NA] I have added tests that prove my fix is effective or that my feature
  works
• My code follows the style guidelines of this project
• My changes generate no new warnings
• [NA] New and existing unit tests pass locally with my changes
• I have committed any related changes to the PR
• Run sqlfluff fix on tables that are created or modified in this PR.
  • Failing due to models outside of this PR. Related to the nature of this sandbox repo.

[chris-s-friedman]

@brendagutman can you please fill out the PR summary?

[chris-s-friedman]

This is a ton of work! thanks for getting on this!

See my individual comments below.

Is the idea with the aadsc models to use them as a template for bootstrapping new studies? If so could it get moved into some sort of a template directory?

[brendagutman]

This is a ton of work! thanks for getting on this!

See my individual comments below.

Is the idea with the aadsc models to use them as a template for bootstrapping new studies? If so could it get moved into some sort of a template directory?

Yes, the aadsc models are more of a template as they are now. A template, to help create templates(pilot harmonizations) 😆. I'd like to keep them where they are. It would be much clearer to everyone and the models can be run as is(everything is null atm) so they shouldn't be 'breaking' anything. I think this is safe enough for the sandbox/dev environment.

I don't expect aadsc to be run with Airflow. As soon as the include-study brainpower pilot is created aadsc(and references) can be removed.

[Christina-J-Diaz]

approving, but also acknowledging the PR has areas that need to be updated. for context: we met with @brendagutman to go through this PR and think it is in a "good enough" state for the sandbox environment, with the idea being that the analysts can start to test out its functionality and submit PRs/issues as issues arise. given how many files and work has gone into this, that may be our best approach :)

[chris-s-friedman]

knowing that all of this is still in active development - I'm kind of seeing this PR as a waypoint on that development journey.

This seems good to me. Like I said above, great work!