IWF-1161: drop unused MockCloudOperationsClient to unblock Temporal SDK upgrade#605
Open
AkilFranklin wants to merge 1 commit into
Open
IWF-1161: drop unused MockCloudOperationsClient to unblock Temporal SDK upgrade#605AkilFranklin wants to merge 1 commit into
AkilFranklin wants to merge 1 commit into
Conversation
…DK upgrade The generated mock for the SDK's CloudOperationsClient interface (MockCloudOperationsClient) was unused by iwf and was the only code importing go.temporal.io/api/cloud/cloudservice/v1. Temporal removed that package from go.temporal.io/api as of api v1.41.0 (the cloud API moved to the separate go.temporal.io/cloud-sdk module), so its presence broke downstream builds (iwf-service) against any Temporal Go SDK >= v1.31, which pulls api >= v1.43. Removing the unused mock (and its cloudservice import) lets consumers build against newer SDKs with no other change. MockClient and the remaining generated mocks are untouched, and the existing temporal client tests still pass. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Removes the generated
MockCloudOperationsClient(and itsgo.temporal.io/api/cloud/cloudservice/v1import) fromservice/client/temporal/real_temporal_client_mock.go.MockClientandMockNamespaceClient— the mocks iwf actually uses — are unchanged.MockCloudOperationsClientis unused anywhere in iwf; it was emitted incidentally when mockgen ran over the SDK's fullclient.go, and it is the only code in iwf importinggo.temporal.io/api/cloud/cloudservice/v1. Temporal removed thecloud/package tree fromgo.temporal.io/apias of api v1.41.0 (the Cloud API moved to the separatego.temporal.io/cloud-sdkmodule). Since any Temporal Go SDK>= v1.31pullsapi >= v1.43, that package no longer exists — so this unused mock breaks the build for any downstream service that upgrades the SDK. Removing it unblocks consumers (e.g. iwf-service) from upgrading the Temporal Go SDK, with no functional change to iwf.Validated downstream against
go.temporal.io/sdk v1.44.1(api v1.62.x): the consumer builds and tests clean, and a replay-determinism sweep over recent production histories reported 0 non-determinism.Checklist
MockClient/MockNamespaceClient) still passRelated Issue
Tracked internally as IWF-1161 (no public issue).
Note
This file is MockGen-generated. Regenerating it in source mode over the SDK
client.gore-emitsMockCloudOperationsClient; if that happens, drop it again. (Reflect mode can't be used to exclude it: the SDK aliases internal types, so reflect-mode mocks import the disallowedgo.temporal.io/sdk/internal.)