small QoL fixes#3916
Merged
Merged
Conversation
awildturtok
force-pushed
the
fix/minor-usability-fixes
branch
2 times, most recently
from
97523ec to
778fff1
Compare
awildturtok
commented
Jul 9, 2026
|
|
||
| return createNamespace(datasetStorage, metaStorage, environment); | ||
| }catch (Exception e) { | ||
| log.error("Error while creating namespace for dataset {}. Deleting.", dataset.getId(), e); |
Collaborator
Author
There was a problem hiding this comment.
Das müsste so reichen, aber ich muss es noch testen
Collaborator
There was a problem hiding this comment.
Du müsstest das try vielleicht erst nach dem
// Each store injects its own IdResolveCtx so each needs its own mapper
datasetStorage.openStores(Jackson.copyMapperAndInjectables(persistenceMapper));
öffnen.
awildturtok
force-pushed
the
fix/minor-usability-fixes
branch
from
778fff1 to
d43d9bd
Compare
thoniTUB
approved these changes
Jul 10, 2026
Comment on lines
+67
to
+68
| hikariConfig.setConnectionTimeout(60_000); | ||
| hikariConfig.setMinimumIdle(3); |
Collaborator
There was a problem hiding this comment.
Warum machst du die nicht parametriesiert? Du bist doch schon in der richtigen Klasse
Collaborator
Author
There was a problem hiding this comment.
Ups, das war testcode, der muss aus der config kommen.
|
|
||
| return createNamespace(datasetStorage, metaStorage, environment); | ||
| }catch (Exception e) { | ||
| log.error("Error while creating namespace for dataset {}. Deleting.", dataset.getId(), e); |
Collaborator
There was a problem hiding this comment.
Du müsstest das try vielleicht erst nach dem
// Each store injects its own IdResolveCtx so each needs its own mapper
datasetStorage.openStores(Jackson.copyMapperAndInjectables(persistenceMapper));
öffnen.
|
|
||
| assertThat(histogram.nodes()).hasSize(3); | ||
| List<Map.Entry<Range<Double>, Histogram.Counter>> nodes = histogram.nodes(); | ||
| log.info("{}", nodes); |
Collaborator
There was a problem hiding this comment.
Suggested change
| log.info("{}", nodes); |
oder die message noch ergänzen
awildturtok
force-pushed
the
fix/minor-usability-fixes
branch
2 times, most recently
from
35e4b16 to
221df88
Compare
awildturtok
force-pushed
the
fix/minor-usability-fixes
branch
from
221df88 to
45b9cfd
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.