Raise PHPStan to level 10

composer.json

@@ -33,6 +33,7 @@
     },
     "require-dev": {
         "phpstan/phpstan": "^2.0",
+        "phpstan/phpstan-phpunit": "^2.0",
         "phpunit/phpunit": "^13.1",
         "squizlabs/php_codesniffer": "^3.10"
     },

phpstan.neon.dist

@@ -1,5 +1,8 @@
+includes:
+    - vendor/phpstan/phpstan-phpunit/extension.neon
+
 parameters:
-    level: 8
+    level: 10
     treatPhpDocTypesAsCertain: false
     paths:
         - src

src/Ast/AstMatchCodec.php

@@ -103,7 +103,7 @@ private function encodeCaptureArray(array $captures): array
     }
 
     /**
-     * @param array<string, mixed> $captures
+     * @param array<array-key, mixed> $captures
      * @return array<string, mixed>
      */
     private function decodeCaptureArray(array $captures): array

src/Ast/AstSearcher.php

@@ -133,7 +133,7 @@ public function compilePattern(string $pattern, AstSearchOptions $options): Patt
 
     /**
      * @param list<Node> $statements
-     * @param callable(): string|string|null $source
+     * @param (callable(): string)|string|null $source
      * @return list<AstMatch>
      */
     public function searchParsedStatements(
@@ -153,9 +153,12 @@ public function searchParsedStatements(
             }
 
             if ($loadedSource === null) {
-                $loadedSource = is_callable($source)
-                    ? (string) $source()
-                    : (string) ($source ?? '');
+                if (is_callable($source)) {
+                    $invoked = $source();
+                    $loadedSource = is_string($invoked) ? $invoked : '';
+                } else {
+                    $loadedSource = $source ?? '';
+                }
             }
 
             $matches[] = $this->createMatch($candidate, $captures, $loadedSource, $file);

src/Ast/PatternMatcher.php

@@ -170,7 +170,7 @@ private function fingerprintNode(Node $node): string
     }
 
     /**
-     * @param array<int, mixed> $subNodeValue
+     * @param array<array-key, mixed> $subNodeValue
      * @return list<string>
      */
     private function serializeSubNodeArray(array $subNodeValue): array

src/Cli/IndexApplication.php

@@ -2274,6 +2274,10 @@ private function directorySize(string $path): int
         );
 
         foreach ($iterator as $entry) {
+            if (!$entry instanceof \SplFileInfo) {
+                continue;
+            }
+
             $entrySize = $entry->getSize();
             $size += is_int($entrySize) ? $entrySize : 0;
         }

src/FeatureMatrix/FeatureMatrixGenerator.php

@@ -9,6 +9,31 @@
 use Greph\Support\ProcessResult;
 use Greph\Support\ToolResolver;
 
+/**
+ * @phpstan-type FeatureMatrixResult array{
+ *   status: string,
+ *   command: ?list<string>,
+ *   exit_code: ?int,
+ *   stdout: string,
+ *   stderr: string,
+ *   note: string
+ * }
+ * @phpstan-type FeatureMatrixRow array{
+ *   feature: string,
+ *   notes: string,
+ *   results: array<string, FeatureMatrixResult>
+ * }
+ * @phpstan-type FeatureMatrixSection array{
+ *   title: string,
+ *   providers: list<string>,
+ *   rows: list<FeatureMatrixRow>
+ * }
+ * @phpstan-type FeatureMatrixReport array{
+ *   generated_at: string,
+ *   root_path: string,
+ *   sections: list<FeatureMatrixSection>
+ * }
+ */
 final class FeatureMatrixGenerator
 {
     private const STATUS_PASS = 'Pass';
@@ -29,26 +54,7 @@ public function __construct(
     }
 
     /**
-     * @return array{
-     *   generated_at: string,
-     *   root_path: string,
-     *   sections: list<array{
-     *     title: string,
-     *     providers: list<string>,
-     *     rows: list<array{
-     *       feature: string,
-     *       notes: string,
-     *       results: array<string, array{
-     *         status: string,
-     *         command: ?list<string>,
-     *         exit_code: ?int,
-     *         stdout: string,
-     *         stderr: string,
-     *         note: string
-     *       }>
-     *     }>
-     *   }>
-     * }
+     * @return FeatureMatrixReport
      */
     public function generate(): array
     {
@@ -1509,7 +1515,7 @@ private function normalizeOutput(string $output, string $workspace): string
     }
 
     /**
-     * @param array<string, mixed> $report
+     * @param FeatureMatrixReport $report
      */
     public function renderMarkdown(array $report): string
     {
@@ -1574,7 +1580,7 @@ private function escapeInline(string $value): string
     }
 
     /**
-     * @return array<string, mixed>
+     * @return FeatureMatrixReport
      */
     public function write(string $markdownPath, string $jsonPath): array
     {
@@ -1888,7 +1894,7 @@ private static function expectGrephTextJson(ProcessResult $result): ?string
         }
 
         foreach ($decoded as $entry) {
-            if (($entry['file'] ?? null) === 'single.txt') {
+            if (is_array($entry) && ($entry['file'] ?? null) === 'single.txt') {
                 return null;
             }
         }

src/Index/AstCacheStore.php

@@ -105,13 +105,17 @@ public function load(string $indexPath): AstCache
          *   cached: bool
          * }> $facts
          */
+        $buildDuration = $metadata['buildDurationMs'] ?? 0.0;
+        $buildDurationMs = is_int($buildDuration) || is_float($buildDuration) ? (float) $buildDuration : 0.0;
+        $stringKeyedMetadata = self::stringKeyed($metadata);
+
         return new AstCache(
             rootPath: $metadata['rootPath'],
             indexPath: Filesystem::normalizePath($indexPath),
             version: $metadata['version'],
             builtAt: $metadata['builtAt'],
-            buildDurationMs: (float) ($metadata['buildDurationMs'] ?? 0.0),
-            lifecycle: IndexLifecycle::fromMetadata($metadata),
+            buildDurationMs: $buildDurationMs,
+            lifecycle: IndexLifecycle::fromMetadata($stringKeyedMetadata),
             nextFileId: $metadata['nextFileId'],
             files: $files,
             facts: $facts,
@@ -295,4 +299,21 @@ private function writeAtomic(string $path, mixed $payload): void
             throw new \RuntimeException(sprintf('Failed to finalize AST cache file: %s', $path));
         }
     }
+
+    /**
+     * @param array<array-key, mixed> $array
+     * @return array<string, mixed>
+     */
+    private static function stringKeyed(array $array): array
+    {
+        $result = [];
+
+        foreach ($array as $key => $value) {
+            if (is_string($key)) {
+                $result[$key] = $value;
+            }
+        }
+
+        return $result;
+    }
 }

src/Index/AstFactExtractor.php

@@ -278,7 +278,13 @@ private function isObjectOperator(mixed $token): bool
 
     private function tokenId(mixed $token): ?int
     {
-        return is_array($token) ? $token[0] : null;
+        if (!is_array($token)) {
+            return null;
+        }
+
+        $id = $token[0] ?? null;
+
+        return is_int($id) ? $id : null;
     }
 
     private function blocksFunctionCallClassification(mixed $previousToken): bool