-
Notifications
You must be signed in to change notification settings - Fork 23
New UI for prep stage #345
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
kirtansakariya
wants to merge
28
commits into
master
Choose a base branch
from
issues/336
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
Show all changes
28 commits
Select commit
Hold shift + click to select a range
de39576
done with skeleton for asciimatics
kirtansakariya 79f7db4
copy before removing comments
kirtansakariya 562df93
removed comments
kirtansakariya 4f8b799
removing booleans meant for highlighting fields
kirtansakariya 07c39d3
added comments
kirtansakariya 4789197
removed most unused variables
kirtansakariya 9299811
making text fields on summary smaller
kirtansakariya 0cc848d
need to handle file selection in file browser
kirtansakariya fe80ac1
handling invalid values for percentages
kirtansakariya d3964bc
adding comments
kirtansakariya 3c7f493
file preview, rearranging wizard screens
kirtansakariya b8abbff
Merge branch 'master' into issues/336
kirtansakariya 6af97af
adding asciimatics to the requirements.txt
kirtansakariya 79e51aa
Merge branch 'master' of https://github.com/inpho/topic-explorer into…
kirtansakariya 4637720
Merge branch 'issues/336' of https://github.com/inpho/topic-explorer …
kirtansakariya 2ffed42
demo works now
kirtansakariya bb38671
working on tests
kirtansakariya 8618c3b
modifying test cases
kirtansakariya 7dcde53
adding asciimatics install to windows build
kirtansakariya 6d43236
adding dividers for wizard screens
kirtansakariya 7b7ede8
raising ValueError now
kirtansakariya af695ed
using instance of unittest.TestCase
kirtansakariya 327d4c5
Merge branch 'master' into issues/336
kirtansakariya 0dbab9c
Merge branch 'master' into issues/336
kirtansakariya a970384
Merge branch 'master' into issues/336
kirtansakariya 7dc3ff7
Merge branch 'master' into issues/336
kirtansakariya 7751cfe
updating asciimatics reqs
JaimieMurdock d470a71
interrupts enabled
kirtansakariya File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,3 +1,4 @@ | ||
| asciimatics>=1.11.0 | ||
| bottle>=0.12.0 | ||
| brewer2mpl>=1.4.0,<1.5.0 | ||
| decorator>=4.0.5 | ||
|
|
||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
is there a particular reason why we need that specific commit for asciimatics? Will it be folded into a release?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
As of right now, the version of asciimatics that we need has not had an official release. I asked them when they plan on doing another release and they said that it would be in a couple of months. So until them, we will have to use that specific commit or the asiimatics repo in general.