BM: fix undefined behavior and checkpatch warnings in cpuid_check#578
Merged
Conversation
Fix extract_bits():
- Add bounds validation for shift operands to prevent UB (CWE-682, CWE-190)
- Use unsigned literals (1U, ~0U) to avoid signed shift UB
Replace single-variable sscanf with strtoul/strtol helpers:
- Add parse_hex() and parse_dec() static functions
- Replace sscanf("%x") with parse_hex() for hex argument parsing
- Replace sscanf("%d") with parse_dec() for decimal argument parsing
- Replace sscanf("%c") with direct character access
- Replace sscanf("%6s") with snprintf
Found by libFuzzer+UBSan fuzzing campaign and CI checkpatch.
Signed-off-by: Farrah Chen <farrah.chen@intel.com>
(cherry picked from commit 7311ef7)
hongyuni
force-pushed
the
sync/hotfix-BM-tools-sdl-fix
branch
from
523e42e to
e982403
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix extract_bits():
Replace single-variable sscanf with strtoul/strtol helpers:
Found by libFuzzer+UBSan fuzzing campaign and CI checkpatch.
(cherry picked from commit 7311ef7)