Open
Conversation
thiagomacieira
requested changes
Apr 24, 2026
Member
thiagomacieira
left a comment
thiagomacieira
left a comment
There was a problem hiding this comment.
Looks good, but can you put the explanation in the commit message? What you used on the PR looks good.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The line
configure_file(tinycbor.pc.in tinycbor.pc @ONLY)generated the file intoCMAKE_CURRENT_BINARY_DIR, but the installation of this file was being done usingCMAKE_BINARY_DIR. This creates an error if tinycbor is added throughadd_subdirectory, because it tries looking that the root binary directory, but doesn't find it there because tinycbor gets its own subdirectory. This should fix the installation by using that specific directory.