Skip to content

Add set -e and --ff-only to release Makefile targets#3

Merged
jabawack81 merged 1 commit into
mainfrom
fix/release-makefile-safety
Apr 9, 2026
Merged

Add set -e and --ff-only to release Makefile targets#3
jabawack81 merged 1 commit into
mainfrom
fix/release-makefile-safety

Conversation

@jabawack81

Copy link
Copy Markdown
Member

Summary

Follow-up from CodeRabbit review on #2 (pushed after merge).

  • Add set -e to release recipe so git failures abort immediately
  • Use git pull --ff-only origin main in tag target to prevent accidental merge commits

Test plan

  • make help shows correct targets
  • make tag VERSION= without a version prints usage and exits

🤖 Generated with Claude Code

- Add set -e to release recipe so git failures abort immediately
  instead of continuing on the wrong branch
- Use git pull --ff-only in tag target to match release target
  and prevent accidental merge commits from being tagged

Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
@coderabbitai

coderabbitai Bot commented Apr 9, 2026

Copy link
Copy Markdown

Warning

Rate limit exceeded

@jabawack81 has exceeded the limit for the number of commits that can be reviewed per hour. Please wait 15 minutes and 31 seconds before requesting another review.

Your organization is not enrolled in usage-based pricing. Contact your admin to enable usage-based pricing to continue reviews beyond the rate limit, or try again in 15 minutes and 31 seconds.

⌛ How to resolve this issue?

After the wait time has elapsed, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

We recommend that you space out your commits to avoid hitting the rate limit.

🚦 How do rate limits work?

CodeRabbit enforces hourly rate limits for each developer per organization.

Our paid plans have higher rate limits than the trial, open-source and free plans. In all cases, we re-allow further reviews after a brief timeout.

Please see our FAQ for further information.

ℹ️ Review info
⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro

Run ID: 240147ce-f12f-4f0b-aede-4aaadfd5f634

📥 Commits

Reviewing files that changed from the base of the PR and between fc6c6bc and 2c75b47.

📒 Files selected for processing (1)
  • Makefile
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch fix/release-makefile-safety

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@jabawack81 jabawack81 merged commit 7664e0f into main Apr 9, 2026
2 checks passed
@jabawack81 jabawack81 deleted the fix/release-makefile-safety branch April 11, 2026 12:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant