Remove password manager autofill references#4
Conversation
Browser security prevents extensions from injecting content scripts into other extensions' pages (chrome-extension:// / moz-extension://), so 1Password, Bitwarden, and other password managers cannot autofill our new tab setup input. The autocomplete="current-password" and name="github-token" changes had no effect — reverting them and removing the misleading CHANGELOG entry. Users should copy the token manually from their password manager's browser extension popup and paste it into the setup input. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (2)
💤 Files with no reviewable changes (1)
📝 WalkthroughWalkthroughA changelog entry about password manager autofill support was removed, and the GitHub token input field in the setup form was modified to remove its Changes
Estimated code review effort🎯 1 (Trivial) | ⏱️ ~3 minutes Poem
🚥 Pre-merge checks | ✅ 3✅ Passed checks (3 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
There was a problem hiding this comment.
Pull request overview
This PR removes previously-added password manager autofill hints from the GitHub token setup input and deletes a misleading changelog entry, aligning the UI/configuration with the reality that password managers can’t inject into extension pages.
Changes:
- Revert the setup token input’s
autocompletetooffand remove thenameattribute. - Remove the “password manager autofill support” entry from the Unreleased changelog.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| newtab.html | Removes autofill-oriented attributes from the setup token <input> while keeping the existing JS flow (token read by id). |
| CHANGELOG.md | Drops a changelog line that no longer reflects actual behavior. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Summary
Browser security prevents password managers (1Password, Bitwarden, etc.) from injecting content scripts into other extensions' pages. Our
autocomplete="current-password"andname="github-token"changes had no effect — both testers confirmed neither 1Password nor Bitwarden autofill the setup input.autocompletetooff, drop thenameattributeUsers must copy their token manually from the password manager popup and paste it.
Test plan
🤖 Generated with Claude Code
Summary by CodeRabbit