Skip to content

[PB-5978]: feat(sidenav)/add notification slot above storage#103

Merged
jzunigax2 merged 4 commits into
masterfrom
feat/notification-inside-sidenav
May 12, 2026
Merged

[PB-5978]: feat(sidenav)/add notification slot above storage#103
jzunigax2 merged 4 commits into
masterfrom
feat/notification-inside-sidenav

Conversation

@jzunigax2
Copy link
Copy Markdown
Contributor

@jzunigax2 jzunigax2 commented May 7, 2026

Adds an optional notification prop to Sidenav, rendered between the options list and the storage section. The slot inherits the existing collapse transition so it auto-hides when the sidenav is collapsed.

imagen

@jzunigax2 jzunigax2 requested a review from CandelR May 7, 2026 21:50
@jzunigax2 jzunigax2 self-assigned this May 7, 2026
@jzunigax2 jzunigax2 requested a review from xabg2 May 7, 2026 21:50
@jzunigax2 jzunigax2 added the enhancement New feature or request label May 7, 2026
Copy link
Copy Markdown
Collaborator

@CandelR CandelR left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If the notification component is always going to be the same, apart from a few minor differences, perhaps it would be better to create it and simply pass the notification text, the button action and the button text to the sidenav itself, and if there are variations in the notification, the type as well. Because at the moment, you can pass it any type of component. What do you think?

@jzunigax2
Copy link
Copy Markdown
Contributor Author

If the notification component is always going to be the same, apart from a few minor differences, perhaps it would be better to create it and simply pass the notification text, the button action and the button text to the sidenav itself, and if there are variations in the notification, the type as well. Because at the moment, you can pass it any type of component. What do you think?

hmm yes I believe it makes sense

@jzunigax2 jzunigax2 requested a review from CandelR May 11, 2026 18:32
@jzunigax2 jzunigax2 merged commit 3e517ab into master May 12, 2026
1 check passed
@jzunigax2 jzunigax2 deleted the feat/notification-inside-sidenav branch May 12, 2026 13:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants