Skip to content

ImportAll work queue manager to import items in parallel in some situations #970

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
raymond-rebbeck wants to merge 2 commits into
base: main
Choose a base branch
from
+26 −1
Open

ImportAll work queue manager to import items in parallel in some situations #970

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
790a98e
In ImportAll create a work queue manager to use for importing items t…
raymond-rebbeck May 16, 2026
1740e10
In ImportAll don't use a work queue manager to import items when deco…
raymond-rebbeck May 16, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
27 changes: 26 additions & 1 deletion cls/SourceControl/Git/Utils.cls
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1670,6 +1670,18 @@ ClassMethod ImportRoutines(force As %Boolean = 0, pullEventClass As %String) As
kill files

set settings = ##class(SourceControl.Git.Settings).%New()

// Create a work queue manager to use for importing items to improve performance
// Currently only used when not compiling and not using decomposed productions
#dim queue as %SYSTEM.WorkMgr = ""
if ('settings.compileOnImport && 'settings.decomposeProductions) {
set queue = ##class(%SYSTEM.WorkMgr).%New()
if (queue = "") {
set ec = $$$ADDSC(ec, %objlasterror)
quit:'ec ec
}
}

#dim internalName as %String = ""
for {
set internalName = $order(itemList(internalName))
Expand Down Expand Up @@ -1697,14 +1709,27 @@ ClassMethod ImportRoutines(force As %Boolean = 0, pullEventClass As %String) As
set files($increment(files)) = modification
} else {
// If not compiling then import now as otherwise it won't happen
set sc = ..ImportItem(internalName, force)
set sc = $$$OK
// If a work queue has been created then use it
if (queue '= "") {
set sc = queue.Queue("..ImportItem", internalName, force)
} else {
set sc = ..ImportItem(internalName, force)
}
if $$$ISERR(sc) {
set ec = $$$ADDSC(ec, sc)
}
}
}
}

// If a work queue was created then wait for all work to finish
if (queue '= "") {
set sc = queue.Sync()
if $$$ISERR(sc) {
set ec = $$$ADDSC(ec, sc)
}
}

//let's delete all items for which corresponding files had been deleted
#dim item as %String = ""
Expand Down
Loading