Skip to content

ci: separate native builds into Android and iOS - #129

Merged
OS-pedrogustavobilro merged 5 commits into
mainfrom
ci/verify-separate-android-ios
Jul 27, 2026
Merged

ci: separate native builds into Android and iOS#129
OS-pedrogustavobilro merged 5 commits into
mainfrom
ci/verify-separate-android-ios

Conversation

@OS-pedrogustavobilro

@OS-pedrogustavobilro OS-pedrogustavobilro commented Jul 17, 2026

Copy link
Copy Markdown
Contributor

To be in accordance to other capacitor plugin repositories we have.

@OS-pedrogustavobilro
OS-pedrogustavobilro requested review from a team and alexgerardojacinto and removed request for a team July 17, 2026 16:16
@OS-pedrogustavobilro
OS-pedrogustavobilro marked this pull request as ready for review July 17, 2026 16:55
- name: 'Build Web example app'
working-directory: ./example-app
shell: bash
run: pnpm run build

@jcesarmobile jcesarmobile Jul 20, 2026

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't think building the plugin and the example app is needed here, build-example-app needs verify-plugin, which needs build-packages, which builds the plugin and both example apps, so they should be built at this point.

And BTW, should we sync/build the example-app-spm too?
I don't think we are doing it in other plugins which has two example apps, but what's the point of having the spm variant if we are not doing anything with it?

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Accidentally didn't reply in thread, refer to my reply on #129 (comment)

@OS-pedrogustavobilro

Copy link
Copy Markdown
Contributor Author

Regarding the plugin build being necessary, yes it's already being applied in the build-packages job, but the dist folder goes away when switching to another (in this case build-example-app) step.

It is possible that the native build passes without the web build, to me it logically makes sense to stay, while still making sense to have the build step separate before so that we can get earlier feedback if web build fails.

As for the example-app-spm native build, you are right, I'll add that step here and to other repos that have it.

We only added example-app-spm to some repositories when we were testing SPM compatibility on plugins that didn't have it (this was one of them). One day we'll only have one example app with SPM, but for now it still makes sense to keep CocoaPods variant imo.

@OS-pedrogustavobilro
OS-pedrogustavobilro merged commit c8a5a28 into main Jul 27, 2026
9 checks passed
@OS-pedrogustavobilro
OS-pedrogustavobilro deleted the ci/verify-separate-android-ios branch July 27, 2026 11:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants