Skip to content

fix(ios): Adjust WebView sizing during keyboard size changes #49

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
GabrielNSD wants to merge 1 commit into
base: main
Choose a base branch
from
Open

fix(ios): Adjust WebView sizing during keyboard size changes #49

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
132 changes: 89 additions & 43 deletions ios/Sources/KeyboardPlugin/Keyboard.m
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -40,6 +40,7 @@ @interface KeyboardPlugin () <UIScrollViewDelegate>
@property (nonatomic, readwrite) ResizePolicy keyboardResizes;
@property (readwrite, assign, nonatomic) NSString* keyboardStyle;
@property (nonatomic, readwrite) int paddingBottom;
@property (nonatomic) NSTimeInterval lastFullDismissalTime;

@end

Expand All @@ -53,7 +54,6 @@ @implementation KeyboardPlugin
NSString* UIClassString;
NSString* WKClassString;
NSString* UITraitsClassString;
double stageManagerOffset;

#pragma mark - Helpers

Expand Down Expand Up @@ -90,6 +90,40 @@ - (BOOL)shouldIgnoreResizeForHeight:(double)height {
return (height / screenHeight) < 0.20;
}

- (BOOL)isFullKeyboardFrame:(CGRect)rect {
return ![self shouldIgnoreResizeForHeight:rect.size.height];
}

- (double)keyboardHeightFromFrame:(CGRect)rect {
if (![self isIPad]) {
return rect.size.height;
}

CGFloat screenHeight = UIScreen.mainScreen.bounds.size.height;
CGFloat keyboardTop = CGRectGetMinY(rect);

if (keyboardTop >= screenHeight) {
return 0;
}

double height;
if ([self isFullKeyboardFrame:rect]) {
height = screenHeight - keyboardTop;
} else {
height = rect.size.height;
}

return height < 0 ? 0 : height;
}

- (double)normalizedKeyboardHeightFromFrame:(CGRect)rect {
double height = [self keyboardHeightFromFrame:rect];
if ([self shouldIgnoreResizeForHeight:height]) {
return 0.0;
}
return height;
}

#pragma mark - Lifecycle

- (UIColor *)colorFromCssColorString:(NSString *)cssColor {
Expand Down Expand Up @@ -192,6 +226,8 @@ - (void)load
[nc addObserver:self selector:@selector(onKeyboardDidShow:) name:UIKeyboardDidShowNotification object:nil];
[nc addObserver:self selector:@selector(onKeyboardWillHide:) name:UIKeyboardWillHideNotification object:nil];
[nc addObserver:self selector:@selector(onKeyboardWillShow:) name:UIKeyboardWillShowNotification object:nil];
[nc addObserver:self selector:@selector(onKeyboardWillChangeFrame:) name:UIKeyboardWillChangeFrameNotification object:nil];
[nc addObserver:self selector:@selector(onKeyboardDidChangeFrame:) name:UIKeyboardDidChangeFrameNotification object:nil];

[nc removeObserver:self.webView name:UIKeyboardWillHideNotification object:nil];
[nc removeObserver:self.webView name:UIKeyboardWillShowNotification object:nil];
Expand Down Expand Up @@ -230,28 +266,7 @@ - (void)onKeyboardWillShow:(NSNotification *)notification
[self updateBackdropColor];

CGRect rect = [[notification.userInfo valueForKey:UIKeyboardFrameEndUserInfoKey] CGRectValue];

double height = rect.size.height;

if ([self isIPad]) {
if (stageManagerOffset > 0) {
height = stageManagerOffset;
} else {
CGRect webViewAbsolute = [self.webView convertRect:self.webView.frame toCoordinateSpace:self.webView.window.screen.coordinateSpace];
height = (webViewAbsolute.size.height + webViewAbsolute.origin.y) - (UIScreen.mainScreen.bounds.size.height - rect.size.height);
if (height < 0) {
height = 0;
}

stageManagerOffset = height;
}
}

BOOL ignored = [self shouldIgnoreResizeForHeight:height];
if (ignored) {
NSLog(@"KeyboardPlugin: Ignoring QuickType Bar (%.1f) -> treat as 0.", height);
height = 0.0;
}
double height = [self normalizedKeyboardHeightFromFrame:rect];

double duration = [[notification.userInfo valueForKey:UIKeyboardAnimationDurationUserInfoKey] doubleValue]+0.2;
[self setKeyboardHeight:(int)height delay:duration];
Expand All @@ -266,25 +281,7 @@ - (void)onKeyboardWillShow:(NSNotification *)notification
- (void)onKeyboardDidShow:(NSNotification *)notification
{
CGRect rect = [[notification.userInfo valueForKey:UIKeyboardFrameEndUserInfoKey] CGRectValue];
double height = rect.size.height;

if ([self isIPad]) {
if (stageManagerOffset > 0) {
height = stageManagerOffset;
} else {
CGRect webViewAbsolute = [self.webView convertRect:self.webView.frame toCoordinateSpace:self.webView.window.screen.coordinateSpace];
height = (webViewAbsolute.size.height + webViewAbsolute.origin.y) - (UIScreen.mainScreen.bounds.size.height - rect.size.height);
if (height < 0) {
height = 0;
}
}
}

BOOL ignored = [self shouldIgnoreResizeForHeight:height];
if (ignored) {
NSLog(@"KeyboardPlugin: (didShow) Ignoring QuickType Bar (%.1f) -> report 0.", height);
height = 0.0;
}
double height = [self normalizedKeyboardHeightFromFrame:rect];

[self resetScrollView];

Expand All @@ -299,8 +296,56 @@ - (void)onKeyboardDidHide:(NSNotification *)notification
[self.bridge triggerWindowJSEventWithEventName:@"keyboardDidHide"];
[self notifyListeners:@"keyboardDidHide" data:nil];
[self resetScrollView];
}

- (void)onKeyboardWillChangeFrame:(NSNotification *)notification
{
if (![self isIPad]) {
return;
}

CGRect rect = [[notification.userInfo valueForKey:UIKeyboardFrameEndUserInfoKey] CGRectValue];
CGFloat screenHeight = UIScreen.mainScreen.bounds.size.height;
CGFloat keyboardTop = CGRectGetMinY(rect);

stageManagerOffset = 0;
if (keyboardTop >= screenHeight) {
self.lastFullDismissalTime = [[NSDate date] timeIntervalSince1970];
return;
}

NSTimeInterval timeSinceFullDismissal = [[NSDate date] timeIntervalSince1970] - self.lastFullDismissalTime;
if (![self isFullKeyboardFrame:rect] && timeSinceFullDismissal < 0.5) {
return;
}

if (![self isFullKeyboardFrame:rect]) {
return;
}

double height = [self normalizedKeyboardHeightFromFrame:rect];
double duration = [[notification.userInfo valueForKey:UIKeyboardAnimationDurationUserInfoKey] doubleValue];
[self setKeyboardHeight:(int)height delay:duration];
[self resetScrollView];

NSString *data = [NSString stringWithFormat:@"{ 'keyboardHeight': %d }", (int)height];
[self.bridge triggerWindowJSEventWithEventName:@"keyboardWillChangeFrame" data:data];
NSDictionary *kbData = @{@"keyboardHeight": [NSNumber numberWithDouble:height]};
[self notifyListeners:@"keyboardWillChangeFrame" data:kbData];
}

- (void)onKeyboardDidChangeFrame:(NSNotification *)notification
{
if (![self isIPad]) {
return;
}

CGRect rect = [[notification.userInfo valueForKey:UIKeyboardFrameEndUserInfoKey] CGRectValue];
double height = [self normalizedKeyboardHeightFromFrame:rect];

NSString *data = [NSString stringWithFormat:@"{ 'keyboardHeight': %d }", (int)height];
[self.bridge triggerWindowJSEventWithEventName:@"keyboardDidChangeFrame" data:data];
NSDictionary *kbData = @{@"keyboardHeight": [NSNumber numberWithDouble:height]};
[self notifyListeners:@"keyboardDidChangeFrame" data:kbData];
}

- (void)setKeyboardHeight:(int)height delay:(NSTimeInterval)delay
Expand Down Expand Up @@ -342,6 +387,7 @@ - (void)_updateFrame
if (self.webView != nil) {
wf = self.webView.frame;
}

switch (self.keyboardResizes) {
case ResizeBody:
{
Expand Down