fix(SystemBars): avoid extra IME padding on API <= 34 in insets passthrough - #8528
Open
MedOussemaNjimi wants to merge 1 commit into
Open
fix(SystemBars): avoid extra IME padding on API <= 34 in insets passthrough#8528MedOussemaNjimi wants to merge 1 commit into
MedOussemaNjimi wants to merge 1 commit into
Conversation
…hrough On API <= 34 the window is not edge-to-edge, so the system already resizes the window when the keyboard is shown. Adding imeInsets.bottom as view padding in the insets passthrough branch doubled the space, leaving a gray area the height of the keyboard above it (seen on Android 10, where the compat IME insets are non-zero after the window resize). This applies the same SDK gate that ionic-team#8439 added to the non-passthrough branch. Fixes ionic-team#8525
MedOussemaNjimi
force-pushed
the
fix/systembars-ime-padding-api34
branch
from
July 12, 2026 17:06
bb8c346 to
b5069f6
Compare
tafelnl
reviewed
Jul 17, 2026
| .build(); | ||
| } | ||
|
|
||
| if (Build.VERSION.SDK_INT >= Build.VERSION_CODES.VANILLA_ICE_CREAM) { |
There was a problem hiding this comment.
The actual fix would be removing this weird if-statement. See my reference implementation here: https://github.com/capacitor-community/safe-area/blob/3042a26e278c7babf83c72c37fa0e1e9c0a32d35/android/src/main/java/com/getcapacitor/community/safearea/SafeAreaPlugin.java#L142
This was referenced Aug 2, 2026
fabiomartino
added a commit
to fabiomartino/capacitor
that referenced
this pull request
Aug 23, 2026
Resolve the SystemBars.java three-way conflict keeping the automatic edge-to-edge and universal keyboard architecture from this branch (ionic-team#8366) while adopting upstream's structural changes: - insetsHandling as a validated string field with Logger.warn fallback (upstream ionic-team#8481), replacing the boolean gate across listener registration, initial CSS variables, and onDOMReady - separate status bar and gesture bar style tracking (upstream ionic-team#8409) - per-bar show/hide with else-if semantics (upstream ionic-team#8480) - viewport JS text block TODO note for the future 'full' option Fold in compatible ideas from open PR ionic-team#8454: - navBarVisible tracking in setHidden so hidden navigation bars do not contribute phantom bottom insets - navigation_bar_height resource fallback for legacy (API < 30) OEM builds reporting zero-height nav insets, suppressed for lint (InternalInsetResource, DiscouragedApi) since no supported API exposes a static navigation bar height - IME visibility fallback below Android O via ime inset bottom > 0 - store requested styles so DEFAULT keeps following system theme changes when reapplied on configuration change or resume PR ionic-team#8528's SDK gate for IME padding needs no code here: this branch never applies window IME padding (keyboard is handled via CSS variables and the inset builder), so double keyboard spacing on API <= 34 cannot occur.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #8525
What
Gates the IME padding in the insets passthrough branch of
SystemBars(WebView >= 140 +viewport-fit=cover) behindBuild.VERSION.SDK_INT >= VANILLA_ICE_CREAM, the same gate that #8439 added to the non-passthrough branch.Why
Since 8.3.0 (#8384), when an input is focused on Android 10, a gray area the height of the keyboard appears above the keyboard — reproducible with a fresh
npm init @capacitor/app@latestapp (whose template usesviewport-fit=cover, so the passthrough branch is taken on devices with WebView >= 140).On API <= 34 Capacitor does not run edge-to-edge, so the system already resizes the window when the IME is shown. On API 29 the compat
WindowInsetsCompat.Type.ime()insets are still reported as the keyboard height after that resize, sov.setPadding(0, 0, 0, imeInsets.bottom)compensated for the keyboard a second time, producing the extra gray space. (On API 30–34 the dispatched IME insets are already consumed after the resize, which is why those versions were unaffected.)#8439 fixed the exact same double-compensation in the non-passthrough branch; the passthrough branch added later in #8424 reintroduced it without the SDK gate. This PR applies the same gate there.
On API 35+ (enforced edge-to-edge) the behavior is unchanged.
Testing
./gradlew compileReleaseJavaWithJavac -b capacitor/build.gradlepasses.npm init @capacitor/app@latest, add an input field, run on Android 10 — the gray space above the keyboard no longer appears, while API 35+ keyboard handling is untouched.