Change library structure to allow ipbus-firmware to be compiled into a separate library - #263
Open
pfindlay-cern wants to merge 2 commits into
Open
Change library structure to allow ipbus-firmware to be compiled into a separate library#263pfindlay-cern wants to merge 2 commits into
pfindlay-cern wants to merge 2 commits into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I've added an explicit library
xil_defaultlibto all files that use xilinx IP. See https://adaptivesupport.amd.com/s/question/0D52E00006iHs8USAS/changing-ip-library-in-vivado?language=en_US. Where theworklibrary was being used to access entity instantiations of Xilinx IP this is updated to usexil_defaultlibinstead.This change allows compilation of the ipbus firmware into its own library. It is not possible to selectively compile Xilinx IP into different libraries. All IPs are compiled into the project's default library.
Could potentially causes issues for any project that: