Fix: Support all hash types in Prefix.sum()#75
Open
sumanjeet0012 wants to merge 2 commits into
Open
Conversation
sumanjeet0012
force-pushed
the
fix-64-prefix-sum-hash-types
branch
from
7efbc8d to
221efe7
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR addresses the limitation where
Prefix.sum()andV1Builder.sum()only supportedsha2-256andsha2-512by hardcodinghashlib.sha256/512. The hashing logic now correctly delegates tomultihash.sum()which supports all registered hash functions inpython-multihash.Changes
Prefix.sum()incid/prefix.pyto usemultihash.sum()instead of manually invokinghashliband checkingmh_type.V0Builder.sum()andV1Builder.sum()incid/builder.pysimilarly to delegate tomultihash.sum().hashlibimports from both modules.tests/test_prefix.pyto ensure various multihash types likesha3-256,blake2b-256, andidentityare supported.