Fix: Support complete multihash type mappings in Prefix#76
Open
sumanjeet0012 wants to merge 2 commits into
Open
Fix: Support complete multihash type mappings in Prefix#76sumanjeet0012 wants to merge 2 commits into
sumanjeet0012 wants to merge 2 commits into
Conversation
sumanjeet0012
force-pushed
the
fix-65-multihash-type-mappings
branch
from
4231e10 to
7d07d6c
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR addresses the issue where
Prefix._mh_types_to_code()andPrefix._mh_code_to_type()were using a hardcoded, incomplete mapping of only 8 multihash types, which led toValueErroron valid multihashes likeidentity,shake-256, andblake3.The mapping logic now properly delegates to the
multihashlibrary which acts as the source of truth for all supported multiformat hash codes.Changes
cid/prefix.pyfor both_mh_types_to_codeand_mh_code_to_type._mh_type_to_codenow usesmultihash.Funcandmultihash.coerce_code()to look up the type name safely._mh_code_to_typenow converts the code back to the canonical name viamultihash.Func.This enables py-cid to parse and serialize any valid prefix supported by python-multihash.