Skip to content

Patch 2026.09.3 - #33010

Open
freearhey wants to merge 4 commits into
masterfrom
patch-2026.09.3
Open

Patch 2026.09.3#33010
freearhey wants to merge 4 commits into
masterfrom
patch-2026.09.3

Conversation

@freearhey

Copy link
Copy Markdown
Contributor

Changes:

  • db:update:
    • When the main feed is deleted, the next feed in the list becomes the main feed
    • When the ~ symbol is used in a request, any existing value in the database must be deleted
  • issue:validate:
    • When attempting to delete the last feed in a channel, the request must be blocked
    • If a logo with the same "Channel ID" and "Logo URL" already exists in the database, the request must be blocked
    • If a city with the same "Wikidata ID" or "City Code" already exists in the database, the request must be blocked

Test results:

npm test                   

> test
> npx vitest run --no-file-parallelism

 ✓ tests/commands/issue/validate.test.ts (22 tests) 37968ms
     ✓ can handle channels:add request  2119ms
     ✓ can handle channels:edit request  1772ms
     ✓ can handle channels:edit request without changes  1771ms
     ✓ can handle channels:remove request  1737ms
     ✓ can handle feeds:add request  1684ms
     ✓ can handle invalid feeds:edit request  1671ms
     ✓ can handle valid feeds:add request  1680ms
     ✓ can handle feeds:edit request without changes  1754ms
     ✓ can handle feeds:remove request  1676ms
     ✓ can handle logos:add request  1684ms
     ✓ can handle logos:add request with duplicate  1645ms
     ✓ can handle logos:edit request  1630ms
     ✓ can handle logos:edit request with new feed id  1660ms
     ✓ can handle logos:edit request without changes  1622ms
     ✓ can handle logos:remove request  1644ms
     ✓ can handle cities:add request  2192ms
     ✓ can handle cities:add request with duplicate  1692ms
     ✓ can handle cities:edit request  1646ms
     ✓ can handle cities:edit request without changes  1663ms
     ✓ can handle cities:remove request  1601ms
     ✓ can handle blocklist:add request  1678ms
     ✓ can handle blocklist:remove request  1740ms
 ✓ tests/commands/db/validate.test.ts (6 tests) 10200ms
     ✓ shows an error if the number of columns in a row is incorrect  1659ms
     ✓ shows an error if one of the lines ends with an invalid character  1646ms
     ✓ shows an error if there are duplicates in the file  1735ms
     ✓ shows an error if the data contains an error  1806ms
     ✓ does not show an error if all data are correct  1721ms
     ✓ shows an error if the row is missing column  1630ms
 ✓ tests/commands/db/check_logos.test.ts (8 tests) 5544ms
     ✓ retries and gives up on persistent 429  5294ms
 ✓ tests/commands/db/update.test.ts (1 test) 1972ms
     ✓ can update db with data from issues  1969ms
 ✓ tests/commands/db/export.test.ts (1 test) 1698ms
     ✓ can export data as json  1695ms

 Test Files  5 passed (5)
      Tests  38 passed (38)
   Duration  59.37s (transform 286ms, setup 0ms, import 690ms, tests 57.38s, environment 1ms)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

2 participants