Skip to content

Visual revisions for accessible reorder/parsons questions - #2257

Open
sjd210 wants to merge 19 commits into
mainfrom
improvement/reorder-styling-fixes
Open

Visual revisions for accessible reorder/parsons questions#2257
sjd210 wants to merge 19 commits into
mainfrom
improvement/reorder-styling-fixes

Conversation

@sjd210

@sjd210 sjd210 commented Jul 20, 2026

Copy link
Copy Markdown
Contributor

Most notably, this PR adds a new useSingleList property to reorder/parsons questions to enable a mode where there is only a "Your answer" list that all items start in, and which must be sorted in place (rather than moving items from "Available items" first). This can only be used for questions where all items are required in the answer (unlike e.g. combined_transformations_r1), and any previous attempts at the question will be displayed only if they already included all items. It should otherwise be fully backwards-compatible.

Other smaller changes:

  • Adds a reorder question VRT alongside the existing parsons one. This question uses the useSingleList property.
    • The regression test page will also be updated once both a content cycle has occurred to let the property be used universally, and the playwright tests have been updated to allow both question types to work.
  • Removes expansion-layout from Isaac for these questions, and for Ada only when useSingleList is on
  • Make list swap button always visible on two-list layout (Parsons indent buttons are still on-hover to preserve space for small items)
  • Remove <pre> from Reorder questions to reinstate correct font and wrapping behaviour
  • Disable reorder buttons in "Available items" column

Also see isaacphysics/isaac-content-editor#128 and isaacphysics/isaac-api#812

@codecov

codecov Bot commented Jul 20, 2026

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 1.72414% with 57 lines in your changes missing coverage. Please review.
✅ Project coverage is 43.18%. Comparing base (e21560d) to head (2ebb12d).
⚠️ Report is 33 commits behind head on main.

Files with missing lines Patch % Lines
...rc/app/components/content/IsaacParsonsQuestion.tsx 0.00% 21 Missing ⚠️
...rc/app/components/content/IsaacReorderQuestion.tsx 0.00% 18 Missing ⚠️
...c/app/components/elements/ParsonsDraggableItem.tsx 0.00% 16 Missing ⚠️
src/app/components/content/IsaacQuestion.tsx 0.00% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2257      +/-   ##
==========================================
- Coverage   43.22%   43.18%   -0.04%     
==========================================
  Files         603      602       -1     
  Lines       25775    25794      +19     
  Branches     7662     8590     +928     
==========================================
- Hits        11141    11139       -2     
- Misses      14585    14598      +13     
- Partials       49       57       +8     

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@sjd210
sjd210 marked this pull request as ready for review July 24, 2026 13:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants