fix: catch fetch errors in displayed and dismissed to prevent unhandled rejections - #330
Open
claude[bot] wants to merge 1 commit into
Open
fix: catch fetch errors in displayed and dismissed to prevent unhandled rejections#330claude[bot] wants to merge 1 commit into
claude[bot] wants to merge 1 commit into
Conversation
msingleton
approved these changes
Aug 13, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Requested by matt · Slack thread
Summary
ApiClient.displayedandApiClient.dismissedcallthis.post(...)without handling a rejected promise. When the underlyingfetchfails (e.g. network error), this produces an unhandled promise rejection that surfaces in Datadog/Bugsnag.This mirrors the existing
.catch((error) => { console.error(error); })pattern already used byApiClient.embedin the same file, applying it todisplayedanddismissedas well.Fixes #329
Generated by Claude Code