Skip to content

fix: persist category renames - #13

Merged
kunihir0 merged 1 commit into
mainfrom
fix/category-rename-persistence-boundary
Aug 2, 2026
Merged

fix: persist category renames#13
kunihir0 merged 1 commit into
mainfrom
fix/category-rename-persistence-boundary

Conversation

@kunihir0

@kunihir0 kunihir0 commented Aug 2, 2026

Copy link
Copy Markdown
Collaborator

Moves category rename persistence out of the view and behind LibraryManager. Failed writes now preserve the prior category and keep editing recoverable.

Validation: 6 focused tests, full ItoTests (360), iOS 15.4 build, and strict SwiftLint.

@kunihir0 kunihir0 self-assigned this Aug 2, 2026
@kunihir0
kunihir0 marked this pull request as ready for review August 2, 2026 10:36
@kunihir0
kunihir0 merged commit 91f10d9 into main Aug 2, 2026
1 check passed
@kunihir0
kunihir0 deleted the fix/category-rename-persistence-boundary branch August 2, 2026 10:36
@kunihir0

kunihir0 commented Aug 3, 2026

Copy link
Copy Markdown
Collaborator Author

Follow-up note: isSaving is set inside the newly created Task, leaving a very small window where two rapid taps could enqueue duplicate rename operations before the button disables. A future cleanup can set isSaving = true synchronously in the button action, guarded by isSaving, before creating the task. Low severity; not a blocker for this merged PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant