Skip to content

feat: icon composer file type #73

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
itsjoshpark merged 7 commits into from
Jul 18, 2026
Merged

feat: icon composer file type #73

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
868df9e
feat: icon composer file type
itsjoshpark Jul 18, 2026
ed878d1
fix: remove reference to AccentColor
itsjoshpark Jul 18, 2026
74a5ea9
docs: rendered icon for README
itsjoshpark Jul 18, 2026
de7b145
fix: delete unused preview assets
itsjoshpark Jul 18, 2026
05cae1b
fix: build
itsjoshpark Jul 18, 2026
8e270b4
temp: remove xcpretty
itsjoshpark Jul 18, 2026
127287f
fix: gated checkin
itsjoshpark Jul 18, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Binary file added .github/images/icon.png
View file
Open in desktop
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
6 changes: 3 additions & 3 deletions .github/workflows/ci.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,13 +6,13 @@ on:

jobs:
build:
runs-on: macos-15
runs-on: macos-26
steps:
- name: Checkout
uses: actions/checkout@v6.0.2
uses: actions/checkout@v7

- name: Setup Xcode Version
uses: maxim-lobanov/setup-xcode@v1.7.0
uses: maxim-lobanov/setup-xcode@v1
with:
xcode-version: latest-stable

Expand Down
6 changes: 3 additions & 3 deletions .github/workflows/gated-checkin.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,13 +6,13 @@ on:

jobs:
build:
runs-on: macos-15
runs-on: macos-26
steps:
- name: Checkout
uses: actions/checkout@v6.0.2
uses: actions/checkout@v7

- name: Setup Xcode Version
uses: maxim-lobanov/setup-xcode@v1.7.0
uses: maxim-lobanov/setup-xcode@v1
with:
xcode-version: latest-stable

Expand Down
34 changes: 13 additions & 21 deletions Front Row.xcodeproj/project.pbxproj
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,6 +12,7 @@
033D450A2BB37FCA001AEBAA /* SeekSliderView.swift in Sources */ = {isa = PBXBuildFile; fileRef = 033D45092BB37FCA001AEBAA /* SeekSliderView.swift */; };
03407ADD2BA90F1100FB4323 /* WindowCommands.swift in Sources */ = {isa = PBXBuildFile; fileRef = 03407ADC2BA90F1100FB4323 /* WindowCommands.swift */; };
0355CA552BA790E5001AF5EA /* Localizable.xcstrings in Resources */ = {isa = PBXBuildFile; fileRef = 0355CA542BA790E5001AF5EA /* Localizable.xcstrings */; };
0386A11F300C28060058EB77 /* AppIcon.icon in Resources */ = {isa = PBXBuildFile; fileRef = 0386A11E300C28060058EB77 /* AppIcon.icon */; };
03B2590E2BB242620071FF7C /* PlayerView.swift in Sources */ = {isa = PBXBuildFile; fileRef = 03B2590D2BB242620071FF7C /* PlayerView.swift */; };
03B259102BB249310071FF7C /* PlayerControlsView.swift in Sources */ = {isa = PBXBuildFile; fileRef = 03B2590F2BB249310071FF7C /* PlayerControlsView.swift */; };
03B712272B96C40C00C1F753 /* AVKit.framework in Frameworks */ = {isa = PBXBuildFile; fileRef = 03B712262B96C40C00C1F753 /* AVKit.framework */; };
Expand All @@ -23,8 +24,6 @@
03E8F3DD2B9F7B350008CE49 /* AppCommands.swift in Sources */ = {isa = PBXBuildFile; fileRef = 03E8F3DC2B9F7B350008CE49 /* AppCommands.swift */; };
03EA68512B9630CF003348BE /* FrontRowApp.swift in Sources */ = {isa = PBXBuildFile; fileRef = 03EA68502B9630CF003348BE /* FrontRowApp.swift */; };
03EA68532B9630CF003348BE /* ContentView.swift in Sources */ = {isa = PBXBuildFile; fileRef = 03EA68522B9630CF003348BE /* ContentView.swift */; };
03EA68552B9630D0003348BE /* Assets.xcassets in Resources */ = {isa = PBXBuildFile; fileRef = 03EA68542B9630D0003348BE /* Assets.xcassets */; };
03EA68582B9630D0003348BE /* Preview Assets.xcassets in Resources */ = {isa = PBXBuildFile; fileRef = 03EA68572B9630D0003348BE /* Preview Assets.xcassets */; };
03EA68612B96523B003348BE /* FileCommands.swift in Sources */ = {isa = PBXBuildFile; fileRef = 03EA68602B96523B003348BE /* FileCommands.swift */; };
03EA68642B965322003348BE /* PlaybackCommands.swift in Sources */ = {isa = PBXBuildFile; fileRef = 03EA68632B965322003348BE /* PlaybackCommands.swift */; };
03EA68672B9654A0003348BE /* PlayEngine.swift in Sources */ = {isa = PBXBuildFile; fileRef = 03EA68662B9654A0003348BE /* PlayEngine.swift */; };
Expand All @@ -45,6 +44,7 @@
033D45092BB37FCA001AEBAA /* SeekSliderView.swift */ = {isa = PBXFileReference; lastKnownFileType = sourcecode.swift; path = SeekSliderView.swift; sourceTree = "<group>"; };
03407ADC2BA90F1100FB4323 /* WindowCommands.swift */ = {isa = PBXFileReference; lastKnownFileType = sourcecode.swift; path = WindowCommands.swift; sourceTree = "<group>"; };
0355CA542BA790E5001AF5EA /* Localizable.xcstrings */ = {isa = PBXFileReference; lastKnownFileType = text.json.xcstrings; path = Localizable.xcstrings; sourceTree = "<group>"; };
0386A11E300C28060058EB77 /* AppIcon.icon */ = {isa = PBXFileReference; lastKnownFileType = folder.iconcomposer.icon; path = AppIcon.icon; sourceTree = "<group>"; };
03B2590D2BB242620071FF7C /* PlayerView.swift */ = {isa = PBXFileReference; lastKnownFileType = sourcecode.swift; path = PlayerView.swift; sourceTree = "<group>"; };
03B2590F2BB249310071FF7C /* PlayerControlsView.swift */ = {isa = PBXFileReference; lastKnownFileType = sourcecode.swift; path = PlayerControlsView.swift; sourceTree = "<group>"; };
03B712262B96C40C00C1F753 /* AVKit.framework */ = {isa = PBXFileReference; lastKnownFileType = wrapper.framework; name = AVKit.framework; path = System/Library/Frameworks/AVKit.framework; sourceTree = SDKROOT; };
Expand All @@ -57,8 +57,6 @@
03EA684D2B9630CF003348BE /* Front Row.app */ = {isa = PBXFileReference; explicitFileType = wrapper.application; includeInIndex = 0; path = "Front Row.app"; sourceTree = BUILT_PRODUCTS_DIR; };
03EA68502B9630CF003348BE /* FrontRowApp.swift */ = {isa = PBXFileReference; lastKnownFileType = sourcecode.swift; path = FrontRowApp.swift; sourceTree = "<group>"; };
03EA68522B9630CF003348BE /* ContentView.swift */ = {isa = PBXFileReference; lastKnownFileType = sourcecode.swift; path = ContentView.swift; sourceTree = "<group>"; };
03EA68542B9630D0003348BE /* Assets.xcassets */ = {isa = PBXFileReference; lastKnownFileType = folder.assetcatalog; path = Assets.xcassets; sourceTree = "<group>"; };
03EA68572B9630D0003348BE /* Preview Assets.xcassets */ = {isa = PBXFileReference; lastKnownFileType = folder.assetcatalog; path = "Preview Assets.xcassets"; sourceTree = "<group>"; };
03EA68602B96523B003348BE /* FileCommands.swift */ = {isa = PBXFileReference; lastKnownFileType = sourcecode.swift; path = FileCommands.swift; sourceTree = "<group>"; };
03EA68632B965322003348BE /* PlaybackCommands.swift */ = {isa = PBXFileReference; lastKnownFileType = sourcecode.swift; path = PlaybackCommands.swift; sourceTree = "<group>"; };
03EA68662B9654A0003348BE /* PlayEngine.swift */ = {isa = PBXFileReference; lastKnownFileType = sourcecode.swift; path = PlayEngine.swift; sourceTree = "<group>"; };
Expand Down Expand Up @@ -86,6 +84,15 @@
/* End PBXFrameworksBuildPhase section */

/* Begin PBXGroup section */
0386A120300C2BAD0058EB77 /* Resources */ = {
isa = PBXGroup;
children = (
0386A11E300C28060058EB77 /* AppIcon.icon */,
0355CA542BA790E5001AF5EA /* Localizable.xcstrings */,
);
path = Resources;
sourceTree = "<group>";
};
03B712252B96C40C00C1F753 /* Frameworks */ = {
isa = PBXGroup;
children = (
Expand Down Expand Up @@ -116,24 +123,14 @@
children = (
03BACB2D2B96C8A800D24F07 /* FrontRowInfo.plist */,
03EA68502B9630CF003348BE /* FrontRowApp.swift */,
03EA68542B9630D0003348BE /* Assets.xcassets */,
0355CA542BA790E5001AF5EA /* Localizable.xcstrings */,
03EA685F2B965224003348BE /* Main Menu */,
03EA68562B9630D0003348BE /* Preview Content */,
0386A120300C2BAD0058EB77 /* Resources */,
03EA686C2B968D86003348BE /* Support */,
03EA68652B965424003348BE /* Views */,
);
path = "Front Row";
sourceTree = "<group>";
};
03EA68562B9630D0003348BE /* Preview Content */ = {
isa = PBXGroup;
children = (
03EA68572B9630D0003348BE /* Preview Assets.xcassets */,
);
path = "Preview Content";
sourceTree = "<group>";
};
03EA685F2B965224003348BE /* Main Menu */ = {
isa = PBXGroup;
children = (
Expand Down Expand Up @@ -267,8 +264,7 @@
isa = PBXResourcesBuildPhase;
buildActionMask = 2147483647;
files = (
03EA68582B9630D0003348BE /* Preview Assets.xcassets in Resources */,
03EA68552B9630D0003348BE /* Assets.xcassets in Resources */,
0386A11F300C28060058EB77 /* AppIcon.icon in Resources */,
0355CA552BA790E5001AF5EA /* Localizable.xcstrings in Resources */,
Comment thread
itsjoshpark marked this conversation as resolved.
);
runOnlyForDeploymentPostprocessing = 0;
Expand Down Expand Up @@ -462,11 +458,9 @@
isa = XCBuildConfiguration;
buildSettings = {
ASSETCATALOG_COMPILER_APPICON_NAME = AppIcon;
ASSETCATALOG_COMPILER_GLOBAL_ACCENT_COLOR_NAME = AccentColor;
CODE_SIGN_STYLE = Automatic;
COMBINE_HIDPI_IMAGES = YES;
CURRENT_PROJECT_VERSION = 20;
DEVELOPMENT_ASSET_PATHS = "\"Front Row/Preview Content\"";
ENABLE_APP_SANDBOX = YES;
ENABLE_HARDENED_RUNTIME = YES;
ENABLE_OUTGOING_NETWORK_CONNECTIONS = YES;
Expand All @@ -491,11 +485,9 @@
isa = XCBuildConfiguration;
buildSettings = {
ASSETCATALOG_COMPILER_APPICON_NAME = AppIcon;
ASSETCATALOG_COMPILER_GLOBAL_ACCENT_COLOR_NAME = AccentColor;
CODE_SIGN_STYLE = Automatic;
COMBINE_HIDPI_IMAGES = YES;
CURRENT_PROJECT_VERSION = 20;
DEVELOPMENT_ASSET_PATHS = "\"Front Row/Preview Content\"";
ENABLE_APP_SANDBOX = YES;
ENABLE_HARDENED_RUNTIME = YES;
ENABLE_OUTGOING_NETWORK_CONNECTIONS = YES;
Expand Down
11 changes: 0 additions & 11 deletions Front Row/Assets.xcassets/AccentColor.colorset/Contents.json
View file
Open in desktop

This file was deleted.

65 changes: 0 additions & 65 deletions Front Row/Assets.xcassets/AppIcon.appiconset/Contents.json
View file
Open in desktop

This file was deleted.

Binary file removed Front Row/Assets.xcassets/AppIcon.appiconset/icon_128x128.png
View file
Open in desktop
Binary file not shown.
Binary file removed Front Row/Assets.xcassets/AppIcon.appiconset/icon_256x256 1.png
View file
Open in desktop
Binary file not shown.
Binary file removed Front Row/Assets.xcassets/AppIcon.appiconset/icon_256x256.png
View file
Open in desktop
Binary file not shown.
Binary file removed Front Row/Assets.xcassets/AppIcon.appiconset/icon_32x32.png
View file
Open in desktop
Binary file not shown.
Binary file removed Front Row/Assets.xcassets/AppIcon.appiconset/icon_512x512 1.png
View file
Open in desktop
Binary file not shown.
Binary file removed Front Row/Assets.xcassets/AppIcon.appiconset/icon_512x512.png
View file
Open in desktop
Binary file not shown.
Binary file removed Front Row/Assets.xcassets/AppIcon.appiconset/icon_512x512@2x.png
View file
Open in desktop
Binary file not shown.
6 changes: 0 additions & 6 deletions Front Row/Assets.xcassets/Contents.json
View file
Open in desktop

This file was deleted.

6 changes: 0 additions & 6 deletions Front Row/Preview Content/Preview Assets.xcassets/Contents.json
View file
Open in desktop

This file was deleted.

Binary file added Front Row/Resources/AppIcon.icon/Assets/Front Row.png
View file
Open in desktop
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
44 changes: 44 additions & 0 deletions Front Row/Resources/AppIcon.icon/icon.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,44 @@
{
"fill" : "system-dark",
"groups" : [
{
"blur-material" : null,
"hidden" : false,
"layers" : [
{
"fill" : "none",
"glass" : false,
"image-name" : "Front Row.png",
"name" : "Front Row",
"position" : {
"scale" : 1.6,
"translation-in-points" : [
0,
0
]
}
}
],
"lighting" : "individual",
"refractivity" : {
"depth" : 0,
"enabled" : false,
"strength" : 0.5
},
"shadow" : {
"kind" : "neutral",
"opacity" : 0.6
},
"specular" : false,
"translucency" : {
"enabled" : true,
"value" : 0.2
}
}
],
"supported-platforms" : {
"squares" : [
"macOS"
]
}
}
0 Front Row/Localizable.xcstrings → Front Row/Resources/Localizable.xcstrings
View file
Open in desktop
File renamed without changes.
2 changes: 1 addition & 1 deletion README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
<p align="center">
<img height="256" src="https://github.com/itsjoshpark/FrontRow/raw/main/Front Row/Assets.xcassets/AppIcon.appiconset/icon_256x256.png" />
<img height="256" src="https://github.com/itsjoshpark/FrontRow/raw/main/.github/images/icon.png" />
</p>

<h1 align="center">Front Row</h1>
Expand Down
Loading