Allow decimal bin heights#10
Merged
Merged
Conversation
Co-Authored-By: Claude <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Bin height in grid units now accepts fractional values (for example 5.5 units for a 38.5 mm bin to fit non-multiple-of-7 drawers). The geometry engine was already continuous in height; this relaxes the four explicit integer guards (generator validation, plan file validation twice, screw form) and changes the height inputs to step 0.5 with free decimal typing. Each height field shows the resulting overall height in mm, derived from the engine HEIGHT_UNIT constant. Grid footprint stays integer; cutout auto-fit still rounds up to whole units.
Build green, 1181 tests pass (3 new).
🤖 Generated with Claude Code