add asset_key_pattern to the s3 builders#193
Merged
Merged
Conversation
Custom regex for deriving (name, version) from s3 object keys, so a pre-release key like mybin-0.1.2-beta-x86_64-... parses as 0.1.2-beta instead of the default matcher's lossy 0.1.2 (#61). The pattern must define name and version named capture groups; it is compiled and validated at build(), surfacing failures as the new Error::InvalidAssetKeyPattern. A custom capture that does not parse as semver skips the key, matching the forge backends' non-semver-tag skip. Unset keeps the default matcher unchanged.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
asset_key_pattern(..)to the s3Update/ReleaseListbuilders: a custom regex for deriving(name, version)from object keys, replacing the built-in matcher whose version group only captures amajor.minor.patchtriple. A pre-release key likemybin-0.1.2-beta-x86_64-...can now parse as0.1.2-betainstead of0.1.2.nameandversionnamed capture groups; compile and validate the pattern atbuild(), surfacing failures as the newError::InvalidAssetKeyPattern(s3feature, source chained).specs/ref-s3-backend.md,specs/ref-errors.md, and the CHANGELOG.Closes #61