WIP: Use a JDK build with recent TLS.#841
Open
arnt wants to merge 1 commit into
Open
Conversation
Author
|
I see that a maintainer needs to bless this to even run the CI for testing. Sorry. Dear maintainers, will you please try? Thanks. |
Contributor
But that's needed for github workflows. I'm pretty sure modified Jenkins is not used for that. Perhaps is indexing on schedule only. Time will tell. |
Contributor
|
And, I'm guessing, this modification would not be considered as trusted by Jenkins instance (and the version from target branch (w/o fix) would be used instead) anyway. So some intervention by maintainers might be needed to verify this change works and does not break anything else. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pull request #833 failed in CI; the root cause appears to be that the JDK used in Jenkinsfile is many years old and its TLS doesn't interoperate well with that of post-2024 maven repos. This switches to a recent Temurin build, which seems to work better (but I've marked this WIP so CI won't spam maintainers if I'm wrong).
As a bonus, it tells the CI to use UTF-8, which is important to many of the new tests in #833. It seems to me that the pom.xml setting should be enough, but what do I know.