Skip to content

perf(startup): create settings webview on demand [4/6] - #314

Merged
jamditis merged 1 commit into
codex/v060-webview-bindingsfrom
codex/v060-lazy-settings-webview
Aug 31, 2026
Merged

perf(startup): create settings webview on demand [4/6]#314
jamditis merged 1 commit into
codex/v060-webview-bindingsfrom
codex/v060-lazy-settings-webview

Conversation

@jamditis

Copy link
Copy Markdown
Owner

Before submitting

These are required. If you're skipping any, say why in this section.

  • I searched existing issues and pull requests (including closed ones) so this isn't a duplicate
  • I tested this change locally

Skipping any of the above? Explain why here:

Frontend compilation and production bundling were tested locally. Native launch timing, CPU, and memory measurements require a packaged desktop runner and are left to release validation.

Description

Fourth PR in the v0.6.0 lightweight-launch stack; based on codex/v060-webview-bindings.

Removes the unconditional hidden settings webview. A small atomic lifecycle creates it once when the tray, a normal second launch, macOS reopen, or an update-check action actually needs it. Permission onboarding and no-tray recovery still request it at launch.

A frontend-ready handshake makes a manual update check durable across first creation, concurrent callers share one creation claim, and portable-mode webview data-directory behavior is preserved.

Related issues

Fixes #288

Testing

  • Added pure launch-policy tests for hidden startup, permissions, and tray availability.
  • Added a concurrent creation-claim test.
  • npx tsc --noEmit
  • npm run build
  • git diff --check
  • Native launch/resource measurements: packaged runner required.

Screenshots / videos (optional)

No visual change.

@chatgpt-codex-connector

chatgpt-codex-connector Bot commented Aug 28, 2026

Copy link
Copy Markdown

Codex Review Summary

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
📝 Code Review Completed 2026-08-28T22:23:34.938875Z fa75c28 PR opened
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

@jamditis
jamditis force-pushed the codex/v060-lazy-settings-webview branch from fa75c28 to d61b51c Compare August 28, 2026 22:22

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: fa75c28bd4

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment thread src-tauri/src/main_window.rs Outdated
Comment thread src/components/update-checker/UpdateChecker.tsx Outdated
@jamditis
jamditis force-pushed the codex/v060-lazy-settings-webview branch from d61b51c to fdd2bde Compare August 28, 2026 22:23
@jamditis
jamditis force-pushed the codex/v060-lazy-settings-webview branch from fdd2bde to 63d58b7 Compare August 28, 2026 22:43
@jamditis

Copy link
Copy Markdown
Owner Author

Release coordination: keep this pull request open and do not merge it into main until AudioBud v0.6.0 is public. The signed candidate at e417154 is being replaced because both SBOMs contain placeholder file hashes. Merging now would change the release base and restart validation. Continue review and CI cleanup, then send the final green SHA.

@jamditis

Copy link
Copy Markdown
Owner Author

Release coordination note: protected v0.6.0 candidate run 33230355853 passed at a8f57a3. Keep pull requests 311 through 317 unmerged until v0.6.0 publication is complete. The Office clean Windows lane is requested to test artifact audiobud-windows-x86_64-v0.6.0-1: NSIS, MSI, portable signatures and installs, press-start/press-stop dictation, delivery, target lock, the v0.5.0 updater, and uninstall. Report exact evidence before any merge or publication.

@jamditis

Copy link
Copy Markdown
Owner Author

Release coordination update for August 31: AudioBud v0.6.0 remains frozen before tagging. Clean Windows validation of run 33230355853 is still required: NSIS, MSI, portable, press-start/press-stop dictation, delivery, target lock, startup, tray, quit, uninstall, and the v0.5.0 updater path. Keep PRs 311 through 317 unmerged. Reply only on PR 311 with availability, exact evidence, or a blocker so the test record stays in one thread.

@jamditis
jamditis force-pushed the codex/v060-lazy-settings-webview branch from 63d58b7 to 4da1929 Compare August 31, 2026 23:02
@jamditis
jamditis force-pushed the codex/v060-lazy-settings-webview branch from 4da1929 to 8c373d7 Compare August 31, 2026 23:16
@jamditis
jamditis merged commit 2fbe329 into main Aug 31, 2026
6 checks passed
@jamditis
jamditis deleted the codex/v060-lazy-settings-webview branch August 31, 2026 23:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Do not load the settings webview during a hidden launch

1 participant