perf(startup): create settings webview on demand [4/6] - #314
Conversation
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
fa75c28 to
d61b51c
Compare
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: fa75c28bd4
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
d61b51c to
fdd2bde
Compare
fdd2bde to
63d58b7
Compare
|
Release coordination: keep this pull request open and do not merge it into |
|
Release coordination note: protected v0.6.0 candidate run 33230355853 passed at a8f57a3. Keep pull requests 311 through 317 unmerged until v0.6.0 publication is complete. The Office clean Windows lane is requested to test artifact audiobud-windows-x86_64-v0.6.0-1: NSIS, MSI, portable signatures and installs, press-start/press-stop dictation, delivery, target lock, the v0.5.0 updater, and uninstall. Report exact evidence before any merge or publication. |
|
Release coordination update for August 31: AudioBud v0.6.0 remains frozen before tagging. Clean Windows validation of run 33230355853 is still required: NSIS, MSI, portable, press-start/press-stop dictation, delivery, target lock, startup, tray, quit, uninstall, and the v0.5.0 updater path. Keep PRs 311 through 317 unmerged. Reply only on PR 311 with availability, exact evidence, or a blocker so the test record stays in one thread. |
63d58b7 to
4da1929
Compare
4da1929 to
8c373d7
Compare
Before submitting
These are required. If you're skipping any, say why in this section.
Skipping any of the above? Explain why here:
Frontend compilation and production bundling were tested locally. Native launch timing, CPU, and memory measurements require a packaged desktop runner and are left to release validation.
Description
Fourth PR in the v0.6.0 lightweight-launch stack; based on
codex/v060-webview-bindings.Removes the unconditional hidden settings webview. A small atomic lifecycle creates it once when the tray, a normal second launch, macOS reopen, or an update-check action actually needs it. Permission onboarding and no-tray recovery still request it at launch.
A frontend-ready handshake makes a manual update check durable across first creation, concurrent callers share one creation claim, and portable-mode webview data-directory behavior is preserved.
Related issues
Fixes #288
Testing
npx tsc --noEmitnpm run buildgit diff --checkScreenshots / videos (optional)
No visual change.