Skip to content

perf(startup): create recording overlay on demand [5/6] - #315

Merged
jamditis merged 1 commit into
codex/v060-lazy-settings-webviewfrom
codex/v060-lazy-recording-overlay
Aug 31, 2026
Merged

perf(startup): create recording overlay on demand [5/6]#315
jamditis merged 1 commit into
codex/v060-lazy-settings-webviewfrom
codex/v060-lazy-recording-overlay

Conversation

@jamditis

Copy link
Copy Markdown
Owner

Before submitting

These are required. If you're skipping any, say why in this section.

  • I searched existing issues and pull requests (including closed ones) so this isn't a duplicate
  • I tested this change locally

Skipping any of the above? Explain why here:

Frontend compilation and production bundling were tested locally. Native overlay creation on Windows, macOS, X11, and Wayland requires CI/release runners.

Description

Fifth PR in the v0.6.0 lightweight-launch stack; based on codex/v060-lazy-settings-webview.

Stops constructing the recording overlay during startup. The first visible recording/transcribing/processing state atomically creates one native overlay, queues the latest state while it loads, and waits for a frontend-ready handshake before emitting it. A stop/cancel clears that queued state so a slow first creation cannot resurrect a completed dictation.

overlay_position = none performs no webview work. Existing platform behavior remains in the on-demand builder: macOS NSPanel settings, Windows no-activate/topmost handling, Linux layer-shell fallback, and portable data-directory routing.

The readiness command changes the overlay chunk from 4.75/1.90 kB to 4.86/1.93 kB raw/gzip.

Related issues

Fixes #289

Testing

  • Added concurrent one-winner creation coverage.
  • Added latest-pending-state coverage.
  • node scripts/generate-webview-bindings.mjs --check
  • npx tsc --noEmit
  • npm run build
  • npx prettier --check ...
  • git diff --check
  • Native overlay smoke tests: CI/release runners required.

Screenshots / videos (optional)

No intended visual change.

@chatgpt-codex-connector

chatgpt-codex-connector Bot commented Aug 28, 2026

Copy link
Copy Markdown

Codex Review Summary

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
📝 Code Review Completed 2026-08-28T22:24:05.115127Z 0f67b97 PR opened
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

@jamditis
jamditis force-pushed the codex/v060-lazy-recording-overlay branch from 0f67b97 to 357a4ec Compare August 28, 2026 22:22
@jamditis
jamditis force-pushed the codex/v060-lazy-recording-overlay branch from 357a4ec to 7b0fdfe Compare August 28, 2026 22:24

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 0f67b97a4b

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment thread src-tauri/src/overlay.rs
Comment thread src-tauri/src/overlay.rs Outdated
@jamditis
jamditis force-pushed the codex/v060-lazy-recording-overlay branch 2 times, most recently from 6f5da0e to 404a663 Compare August 28, 2026 22:45
@jamditis

Copy link
Copy Markdown
Owner Author

Release coordination: keep this pull request open and do not merge it into main until AudioBud v0.6.0 is public. The signed candidate at e417154 is being replaced because both SBOMs contain placeholder file hashes. Merging now would change the release base and restart validation. Continue review and CI cleanup, then send the final green SHA.

@jamditis

Copy link
Copy Markdown
Owner Author

Release coordination note: protected v0.6.0 candidate run 33230355853 passed at a8f57a3. Keep pull requests 311 through 317 unmerged until v0.6.0 publication is complete. The Office clean Windows lane is requested to test artifact audiobud-windows-x86_64-v0.6.0-1: NSIS, MSI, portable signatures and installs, press-start/press-stop dictation, delivery, target lock, the v0.5.0 updater, and uninstall. Report exact evidence before any merge or publication.

@jamditis

Copy link
Copy Markdown
Owner Author

Release coordination update for August 31: AudioBud v0.6.0 remains frozen before tagging. Clean Windows validation of run 33230355853 is still required: NSIS, MSI, portable, press-start/press-stop dictation, delivery, target lock, startup, tray, quit, uninstall, and the v0.5.0 updater path. Keep PRs 311 through 317 unmerged. Reply only on PR 311 with availability, exact evidence, or a blocker so the test record stays in one thread.

@jamditis
jamditis force-pushed the codex/v060-lazy-recording-overlay branch from 404a663 to 1471391 Compare August 31, 2026 23:02
@jamditis
jamditis force-pushed the codex/v060-lazy-recording-overlay branch from 1471391 to e1fe850 Compare August 31, 2026 23:17
@jamditis
jamditis merged commit 8d7722a into main Aug 31, 2026
6 checks passed
@jamditis
jamditis deleted the codex/v060-lazy-recording-overlay branch August 31, 2026 23:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Create the recording overlay only when dictation needs it

1 participant