perf(startup): create recording overlay on demand [5/6] - #315
Conversation
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
0f67b97 to
357a4ec
Compare
357a4ec to
7b0fdfe
Compare
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 0f67b97a4b
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
6f5da0e to
404a663
Compare
|
Release coordination: keep this pull request open and do not merge it into |
|
Release coordination note: protected v0.6.0 candidate run 33230355853 passed at a8f57a3. Keep pull requests 311 through 317 unmerged until v0.6.0 publication is complete. The Office clean Windows lane is requested to test artifact audiobud-windows-x86_64-v0.6.0-1: NSIS, MSI, portable signatures and installs, press-start/press-stop dictation, delivery, target lock, the v0.5.0 updater, and uninstall. Report exact evidence before any merge or publication. |
|
Release coordination update for August 31: AudioBud v0.6.0 remains frozen before tagging. Clean Windows validation of run 33230355853 is still required: NSIS, MSI, portable, press-start/press-stop dictation, delivery, target lock, startup, tray, quit, uninstall, and the v0.5.0 updater path. Keep PRs 311 through 317 unmerged. Reply only on PR 311 with availability, exact evidence, or a blocker so the test record stays in one thread. |
404a663 to
1471391
Compare
1471391 to
e1fe850
Compare
Before submitting
These are required. If you're skipping any, say why in this section.
Skipping any of the above? Explain why here:
Frontend compilation and production bundling were tested locally. Native overlay creation on Windows, macOS, X11, and Wayland requires CI/release runners.
Description
Fifth PR in the v0.6.0 lightweight-launch stack; based on
codex/v060-lazy-settings-webview.Stops constructing the recording overlay during startup. The first visible recording/transcribing/processing state atomically creates one native overlay, queues the latest state while it loads, and waits for a frontend-ready handshake before emitting it. A stop/cancel clears that queued state so a slow first creation cannot resurrect a completed dictation.
overlay_position = noneperforms no webview work. Existing platform behavior remains in the on-demand builder: macOS NSPanel settings, Windows no-activate/topmost handling, Linux layer-shell fallback, and portable data-directory routing.The readiness command changes the overlay chunk from 4.75/1.90 kB to 4.86/1.93 kB raw/gzip.
Related issues
Fixes #289
Testing
node scripts/generate-webview-bindings.mjs --checknpx tsc --noEmitnpm run buildnpx prettier --check ...git diff --checkScreenshots / videos (optional)
No intended visual change.