Add new JSON-RPC API calls, with documentation#3660
Add new JSON-RPC API calls, with documentation#3660digable1 wants to merge 2 commits intojamulussoftware:mainfrom
Conversation
|
Please add a note if this was coded with Claude (in this PR) |
|
line re-formatted, should now satisfy clang-format (surprised that C style doesn't like splitting lines to avoid left-right scroll, but ok - so used to Java/Javascript/Typescript styles where that is either encouraged or at least not flagged) Also added the callout to Claude (as stated in the PR, because I used Claude Pro there is no copyright/ownership issue - Anthropic explicitly calls that out). |
|
Please push the changes to this PR. It doesn't seem to be pushed. |
|
Take 2 (yeah I'm supposed to know what I'm doing - whoops!). |
|
Is there already a "set current directory" call? Without one, I'm not sure of the purpose here. Please clarify how this meets the "keep it simple and small" principle. |
|
The purpose is to obtain ping time for that server. This means I do need to know what the current directory is so I can monitor serverInfoReceived and match the address to get it. I don't need to play puppet to the Jamulus UI by being able to set the current directory (I personally don't have a use case for it, and couldn't image anybody else needing it either). And not considering setters avoids error handling for parameter validation. |
Short description of changes
Adds two JSON-RPC API calls: jamulusclient/getDirectories and jamulusclient/getCurrentDirectory.
jamulusclient/getDirectories: Gets the current list of directories.
jamulusclient/getCurrentDirectory: Gets the current directory the client is referencing.
Does this change need documentation? What needs to be documented and how?
JSON-RPC.md has been updated to include documentation for these new API calls
Status of this Pull Request
What is missing until this pull request can be merged?
Nothing
Has been smoke tested to validate we're returning what we think we are.
AUTOBUILD: Please build all targets
Co-Authored-By: Claude Sonnet 4.6 noreply@anthropic.com
(100% done under Claude Pro - which means Anthropic explicitly states that no ownership/control is asserted)