Skip to content

Add new JSON-RPC API calls, with documentation#3660

Open
digable1 wants to merge 2 commits intojamulussoftware:mainfrom
digable1:main
Open

Add new JSON-RPC API calls, with documentation#3660
digable1 wants to merge 2 commits intojamulussoftware:mainfrom
digable1:main

Conversation

@digable1
Copy link
Copy Markdown

@digable1 digable1 commented Apr 23, 2026

Short description of changes

Adds two JSON-RPC API calls: jamulusclient/getDirectories and jamulusclient/getCurrentDirectory.

jamulusclient/getDirectories: Gets the current list of directories.
jamulusclient/getCurrentDirectory: Gets the current directory the client is referencing.

Does this change need documentation? What needs to be documented and how?

JSON-RPC.md has been updated to include documentation for these new API calls

Status of this Pull Request

What is missing until this pull request can be merged?

Nothing

Has been smoke tested to validate we're returning what we think we are.

  • [x ] I've verified that this Pull Request follows the general code principles
  • [ x] I tested my code and it does what I want
  • [ x] My code follows the style guide
  • I waited some time after this Pull Request was opened and all GitHub checks completed without errors.
  • I've filled all the content above

AUTOBUILD: Please build all targets

Co-Authored-By: Claude Sonnet 4.6 noreply@anthropic.com
(100% done under Claude Pro - which means Anthropic explicitly states that no ownership/control is asserted)

@ann0see ann0see added this to Tracking Apr 24, 2026
@github-project-automation github-project-automation Bot moved this to Triage in Tracking Apr 24, 2026
@ann0see
Copy link
Copy Markdown
Member

ann0see commented Apr 24, 2026

Please add a note if this was coded with Claude (in this PR)

@digable1
Copy link
Copy Markdown
Author

line re-formatted, should now satisfy clang-format (surprised that C style doesn't like splitting lines to avoid left-right scroll, but ok - so used to Java/Javascript/Typescript styles where that is either encouraged or at least not flagged)

Also added the callout to Claude (as stated in the PR, because I used Claude Pro there is no copyright/ownership issue - Anthropic explicitly calls that out).

@ann0see
Copy link
Copy Markdown
Member

ann0see commented Apr 24, 2026

Please push the changes to this PR. It doesn't seem to be pushed.

@ann0see ann0see moved this from Triage to Waiting on Team in Tracking Apr 24, 2026
@digable1
Copy link
Copy Markdown
Author

Take 2 (yeah I'm supposed to know what I'm doing - whoops!).

@ann0see ann0see requested review from ann0see and pljones April 25, 2026 08:20
@pljones
Copy link
Copy Markdown
Collaborator

pljones commented Apr 25, 2026

Is there already a "set current directory" call? Without one, I'm not sure of the purpose here.

Please clarify how this meets the "keep it simple and small" principle.

@digable1
Copy link
Copy Markdown
Author

The purpose is to obtain ping time for that server. This means I do need to know what the current directory is so I can monitor serverInfoReceived and match the address to get it.

I don't need to play puppet to the Jamulus UI by being able to set the current directory (I personally don't have a use case for it, and couldn't image anybody else needing it either). And not considering setters avoids error handling for parameter validation.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Status: Waiting on Team

Development

Successfully merging this pull request may close these issues.

3 participants