fix(segcache): prevent boot stream truncation via blocking catalog hydration with 30s timeout safety - #877
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Fixes cold-start stream truncation by synchronizing segment cache access during startup catalog hydration.
Problem
Previously (#757), catalog loading was moved to a background goroutine and gated by an
atomic.Bool loadingflag. When a client requested a stream immediately after server boot:c.itemswas empty, soGet()returned misses for all cached segments.Put()silently skipped caching whileloadingwas true, and anyPut()that landed before the flag was set was clobbered whenLoadCatalog()assignedc.items = valid.http.ServeContenthad already committed the206 Partial Contentheader andContent-Length, resulting in an unexpected connection drop mid-stream (curl 18).Solution
loadingboolean with aready chan struct{}andsync.Once.c.waitReady()before accessing the map.30 * time.Secondbounded timeout (HydrationTimeout, configurable viaConfig) so degraded physical disk I/O or an uncalledLoadCatalognever indefinitely deadlocks streaming goroutines.Verification
go test ./...passed across all packages.golangci-lintpassed with 0 issues.