test: pin platform in git-preflight probes that assumed a Linux host - #1179
Open
PatrickKalkman wants to merge 1 commit into
Open
test: pin platform in git-preflight probes that assumed a Linux host#1179PatrickKalkman wants to merge 1 commit into
PatrickKalkman wants to merge 1 commit into
Conversation
Three probeSandboxGit tests left `platform` unset and inherited process.platform, so on darwin they took the sandbox-exec branch and failed while CI on Linux passed. The sibling tests already pin the platform; these now do the same. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01Rf5tbgdUDmHzKnNXpiJLvg
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
This was referenced Aug 29, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
probeSandboxGittests insrc/sandbox/git-preflight.test.tsbuild their probe input without aplatform, so they inherit the host's. They were written against the bwrap path and fail on a macOS host, where the probe takes thesandbox-execbranch instead:fails naming the resolved binary and the exec detail,assertSandboxGit throws the typed error carrying the binary path, andskips with ok when the platform sandbox wrapper is missing.platform: "linux"on those three inputs, the same way the neighbouring darwin cases already pin theirs. No behaviour change; the tests now assert what they were written to assert on every host.Changes
src/sandbox/git-preflight.test.ts— threeplatform: "linux"lines.Test plan
bun run check:all— 12/12 gates on a macOS host (previouslycheck:coveragefailed with the three tests above)linuxWhy it matters
check:allis the pre-commit gate, so on a macOS contributor host these three failures block every commit in the repository until worked around. This is a prerequisite for contributing from macOS at all; I hit it while building the Azure DevOps tracker extension (#1173).🤖 Generated with Claude Code
https://claude.ai/code/session_01Rf5tbgdUDmHzKnNXpiJLvg