Make InternetArchiveProtocol refine Sendable - #95
Merged
Conversation
The concrete InternetArchive is already @unchecked Sendable, but callers only have the protocol type. Refining Sendable lets an actor (or any isolated context) hold an any InternetArchiveProtocol and pass it across isolation boundaries without a data-race diagnostic. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01Cf7er8mrabacGCMtLjd6mQ
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #95 +/- ##
=======================================
Coverage 92.55% 92.55%
=======================================
Files 13 13
Lines 672 672
=======================================
Hits 622 622
Misses 50 50 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #94
Refines
InternetArchiveProtocol: Sendableso callers can hold anany InternetArchiveProtocolinside an actor or send it across isolation boundaries. The concreteInternetArchiveis already@unchecked Sendable, so no conformers change. Main target and tests both build.🤖 Generated with Claude Code
https://claude.ai/code/session_01Cf7er8mrabacGCMtLjd6mQ