[artifactory] allow custom nginx config files and snippets#2290
Open
rufdoSICKAG wants to merge 1 commit into
Open
[artifactory] allow custom nginx config files and snippets#2290rufdoSICKAG wants to merge 1 commit into
rufdoSICKAG wants to merge 1 commit into
Conversation
rufdoSICKAG
force-pushed
the
custom-nginx-config
branch
from
May 4, 2026 11:40
5d41d95 to
7e37365
Compare
Collaborator
|
@rufdoSICKAG Thanks for the PR , Did you get chance to test the PR with proposed solution ? Can you pls share a sample values , so that a test can be added (from our side for this implementation) |
chukka
reviewed
Jul 24, 2026
| } | ||
| } | ||
| {{- if .Values.nginx.customServerSnippet }} | ||
| {{ .Values.nginx.customServerSnippet }} |
Collaborator
There was a problem hiding this comment.
For consistency and to allow templating inside the snippet, use {{ tpl .Values.nginx.customServerSnippet . }} ?
chukka
reviewed
Jul 24, 2026
|
|
||
| customConfFile: "" | ||
| # custom.conf: | | ||
| # log_format ningxartifactory '$proxy_protocol_addr - $remote_user [$time_local] "$request"'; |
chukka
reviewed
Jul 24, 2026
| # custom.conf: | | ||
| # log_format ningxartifactory '$proxy_protocol_addr - $remote_user [$time_local] "$request"'; | ||
| customServerSnippet: "" | ||
| # access_log /dev/stdout ningxartifactory; |
chukka
reviewed
Jul 24, 2026
| {{- end }} | ||
| {{- if .Values.nginx.customConfFile }} | ||
| {{ tpl .Values.nginx.customConfFile . | indent 2 }} | ||
| {{ end }} |
Collaborator
There was a problem hiding this comment.
{{ end }} should be {{- end }}
chukka
reviewed
Jul 24, 2026
| {{- end }} | ||
| {{- if .Values.nginx.customConfFile }} | ||
| {{ tpl .Values.nginx.customConfFile . | indent 2 }} | ||
| {{ end }} |
Collaborator
There was a problem hiding this comment.
{{ end }} should be {{- end }}
This allows to add nginx config files and snippets to customize nginx behavior. An example use case would be, adding a config file containing log_formats and refering to one of those log_formats in a snippet setting a custom access_log.
rufdoSICKAG
force-pushed
the
custom-nginx-config
branch
from
July 24, 2026 12:18
7e37365 to
6ab830b
Compare
Author
|
I made the suggested changes and rebased the branch to the current master |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This allows to add nginx config files and snippets to customize nginx behavior. An example use case would be, adding a config file containing log_formats and refering to one of those log_formats in a snippet, setting a custom access_log.
PR Checklist
[Place an '[x]' (no spaces) in all applicable fields. Please remove unrelated fields.]
[artifactory])What this PR does / why we need it:
This allows to add nginx config files and snippets to customize nginx behavior. An example use case would be, adding a config file containing log_formats and refering to one of those log_formats in a snippet, setting a custom access_log.