Jfrogpipelines#3422
Merged
naveenku-jfrog merged 1 commit intomasterfrom May 4, 2026
Merged
Conversation
naveenku-jfrog
added
the
safe to test
naveenku-jfrog
added
safe to test
naveenku-jfrog
added
safe to test
naveenku-jfrog
added
safe to test
naveenku-jfrog
added
safe to test
naveenku-jfrog
force-pushed
the
jfrogpipelines
branch
from
1000619 to
0a1a622
Compare
naveenku-jfrog
force-pushed
the
jfrogpipelines
branch
from
0a1a622 to
505bd84
Compare
bhanurp
reviewed
Apr 28, 2026
Comment on lines
+4
to
+14
| inputs: | ||
| jfrog_url: | ||
| description: "External JFrog Platform URL. Leave empty for local Artifactory." | ||
| type: string | ||
| required: false | ||
| default: "" | ||
| jfrog_admin_token: | ||
| description: "Admin token for external JFrog Platform." | ||
| type: string | ||
| required: false | ||
| default: "" |
Contributor
There was a problem hiding this comment.
this looks like repeating pattern fr all the files can it be made generic?
Collaborator
Author
There was a problem hiding this comment.
GitHub Actions has no mechanism to share or inherit workflow_dispatch input definitions across workflow files. Each file must declare its own inputs independently — this is a documented platform limitation, not a design choice we can easily escape.
| run: go test -v github.com/jfrog/jfrog-cli --timeout 0 --test.plugins | ||
| run: >- | ||
| go test -v github.com/jfrog/jfrog-cli --timeout 0 --test.plugins | ||
| ${{ env.JFROG_TESTS_IS_EXTERNAL == 'true' && format('--jfrog.url={0} --jfrog.adminToken={1}', env.JFROG_TESTS_URL, env.JFROG_TESTS_LOCAL_ACCESS_TOKEN) || '' }} |
Contributor
There was a problem hiding this comment.
since token is used here, does tests leak the token used fr tests? were you able to verify?
Collaborator
Author
There was a problem hiding this comment.
This is the already used style in all workflows. Refer: https://github.com/jfrog/jfrog-cli/blob/master/.github/workflows/artifactoryTests.yml#L82
bhanurp
approved these changes
Apr 30, 2026
agrasth
approved these changes
May 4, 2026
…actory - Update pipelines.yml and workflow files so tests run correctly against external (cloud) Artifactory from GHE-hosted runners - Skip TestReleaseBundleImportOnPrem on snapshot Artifactory versions - Skip bulk repo create/update subtests on snapshot Artifactory versions - Drop transferTests.yml from the JFrog Pipelines dispatch list - Fix nested-path Docker tests: remove .Build() filter to avoid SDK reader panic - Exclude TestNpmPublishWithNpmrc, TestNpmPublishWithNpmrcScoped and TestNpmPublishWithWorkspacesRunNative via workflow-level -skip flag - Fix TestMavenDeploy: add ensureMavenRepoCleanOfDeployedArtifacts() and increase assertMavenArtifactsEventuallyNotDeployed pollTimeout to 3 minutes - Harden NuGet retry: wrap runNuGet() with execNuGetWithTransientRetry() - Fix TestGradleBuildWithServerID flakiness: retry artifact search for async indexing - Fix TestSetupGradleCommand: evict remote-repo cache before precondition check - Restore virtual-repo build+pattern test cases (TestArtifactoryDownloadByPatternAndBuildFromVirtualRepo, TestArtifactoryDownloadByPatternAndBuildFromVirtualRepoUsingSpec, TestArtifactorySearchByPatternAndBuildFromVirtualRepo) - Point install-local-artifactory action to @main - Point jfrog-cli-workflows ref to master after bugfix branch was merged Co-authored-by: Cursor <cursoragent@cursor.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
masterbranch.go vet ./....go fmt ./....Updated pipelines.yml and access.test so that these tests become compatible with tests running in GHE runners.