fix: enable scrolling to bottom on detail pages on mobile#13
Merged
Conversation
cadc5c5 to
61e5866
Compare
|
🎉 This PR is included in version 2.9.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Two root causes prevented scrolling to the bottom of detail pages
(e.g. Eggs, Pets) on mobile browsers when content was only slightly
taller than the visible viewport:
CollectionsLayout used
100vhfor the inner window on mobile.On Android/iOS,
100vhincludes browser chrome (address bar +nav buttons), so when content fills
100vhbut not the actualvisible area, the scrollable range is too small to reach the
chrome-hide threshold leaving the bottom content permanently
obscured. Changed to
100dvh(Dynamic Viewport Height), whichalways equals the current visible area and adjusts as chrome
shows or hides.
Every detail component (EggsComponent, PetsComponent, etc.) sets
height: 100% on its root div. That resolves against the scroll
container clientHeight, clamping the component layout box to that
fixed height. Overflowing content (overflow: visible) may not
register in the scroll container scrollHeight across all browsers,
making the page appear non-scrollable. Added a plain div wrapper
inside the scroll container in DynamicCollectionConfigData: since
the wrapper has no explicit height, child components height: 100%
resolves to auto (natural content height), so scrollHeight
correctly reflects full content.
Affects all detail routes (/collections/:collection/:item).
Co-Authored-By: Claude Sonnet 4.6 noreply@anthropic.com
Claude-Session: https://claude.ai/code/session_01Tp4RJb9XQn3JzDFu2Fnht4