Fix/local power fix: now local power calculation using Schoenfeld information scale - #5
Merged
Conversation
Pass info_scale='h0_info' to gs_power_ahr() so local power (Table 5) uses null information throughout, matching rpact analytical results. The default 'h0_h1_info' mixed null-boundary with alt-spread, producing power values that matched neither simulation nor Schoenfeld.
- Add tests/testthat/fixtures/local_power_validation_config.R: minimal single-stratum, 1:4 allocation, HR=0.55, asOF, piecewise hazard fixture config purpose-built for numerical validation (not a real study design) - Add tests/testthat/test-local-power-rpact.R: Tier 2 rpact cross-validation of H2 OS local power across all weight scenarios; all rpact inputs derived from config and result — no hardcoded numerics except tolerance - Observed max difference vs rpact: 2e-06 (tolerance: 0.002) - Tests skip on CRAN and when rpact is not installed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Local power values in Table 5 were computed using the alternative
information scale (
"alt_info"), which overstates power under the null.This fix switches to
info_scale = "h0_info"(Schoenfeld), consistentwith how rpact and gsDesign2 define local power.
Changes
R/utils-process.R: setinfo_scale = "h0_info"inget_boundaries()for TTE hypotheses
Validation
Added Tier 2 rpact cross-validation tests (
tests/testthat/test-local-power-rpact.R):tests/testthat/fixtures/local_power_validation_config.R): 1:4 allocation, HR=0.55, piecewise hazard, asOF spendingrpact::getPowerSurvival()calculation across all weight scenarios