436 fr function format sigfig j

[iaugusty]

Pull Request

Fixes #436

Checks

• (Have you updated the NEWS.md ?)
• (Have you added proper tests for new functions/features ?)
• (Have you added new functions to the pkgdown.yml ?)
• (Have you run document() on new functions ?)

[wwojciech]

Overall, the idea looks good to me. Nevertheless, it would be good to clarify and potentially improve some of the design assumptions and implementation details, as indicated in my comments.

Please also check whether the CI/CD failure is related to the new code.

[wwojciech]

I'd aim for the most straightforward extension of base::signif(): preserve its behavior while allowing custom rounding, including the support for round_fun that does not support negative digits; and an optional zero_threshold.

I propose:

signif_j <- function(
  x,
  digits = 6,
  zero_threshold = 0,
  round_fun = round_fmt,
  ...
)

Here, ... are passed as arguments to round_fun.

[munoztd0]

Overall, the idea looks good to me. Nevertheless, it would be good to clarify and potentially improve some of the design assumptions and implementation details, as indicated in my comments.

Please also check whether the CI/CD failure is related to the new code.

CI/CD issues are not related to us, just ubuntu stuff, will resolveshortly