fix: every run adds newlines in web/index.html#817
Conversation
|
@nicholaschiang can you verify this fixes #816? |
Would it be possible for you to test it yourself? I would like to use the upstream version in my project instead of my fork. Thanks |
|
Without looking too much at the code, I can at least confirm that this fixes the missing idempotency for |
|
@moritz-hoelting Can you please remove the |
rather than removing and adding elements (including whitespace), replacing the element if it exists does not add newlines
moritz-hoelting
force-pushed
the
fix/web-increasing-newlines
branch
from
ae571de to
d4d45aa
Compare
done |
|
|
||
| // Update splash image | ||
| document.querySelector('picture#splash')?.remove(); | ||
| document.querySelector('div#splash')?.remove(); |
There was a problem hiding this comment.
We should probably still keep this for now (same as above)
| document.querySelector('picture#splash')?.remove(); | ||
| document.querySelector('picture#splash-branding')?.remove(); |
There was a problem hiding this comment.
Any reason for dropping these?
3 participants
Rather than removing and adding elements (including whitespace), replacing the element if it exists does not add newlines.
Fixes the issue mentioned in #816.