deps: upgrade go-github v68 to v88#217
Merged
Merged
Conversation
Upgrade Go module dependencies to latest: - github.com/google/go-github/v68 -> v88 (major, breaking API) - github.com/anthropics/anthropic-sdk-go v1.53.0 -> v1.54.0 Adapt to go-github v88 API changes: - NewClient now returns (*Client, error) and takes ClientOptionsFunc options; use gh.WithAuthToken / gh.WithHTTPClient instead of the removed (*Client).WithAuthToken method. - IssueListByRepoOptions embeds both ListCursorOptions and ListOptions, so qualify the ambiguous Page selector as ListOptions.Page. - CreateWorkflowDispatchEventByID now returns three values. - BaseURL/UploadURL fields are unexported; the test helper now routes requests through a URL-rewriting http.Client transport so existing mock handlers keep matching. Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow-up to #216 (already merged), which upgraded most dependencies but left
github.com/google/go-githubat v68. This PR completes the upgrade by bumping it to the latest major, v88, and adapts the code to the breaking API changes.anthropics/anthropic-sdk-gois already atv1.54.0onmain(from #216); the npm projects (web/,cmd/screenshots) are already at their latest versions under the repo's 7-day release-age cooldown, so no further changes were needed there.Dependency change
github.com/google/go-github/v68->v88(major, breaking API)go-github v88 API migrations
NewClientnow returns(*Client, error)and acceptsClientOptionsFuncoptions. Replaced the removed(*Client).WithAuthTokenmethod with thegh.WithAuthToken(...)option and added error handling.IssueListByRepoOptionsnow embeds bothListCursorOptionsandListOptions, making the barePageselector ambiguous - qualified asListOptions.Page.CreateWorkflowDispatchEventByIDnow returns three values.BaseURL/UploadURLclient fields are now unexported. The test helper routes requests through a small URL-rewritinghttp.Clienttransport so existing mock handlers keep matching.Verification
go build ./...,go vet ./...,go mod tidy(clean),gofmt/gofumptcleango test ./internal/github/...andgo test ./internal/panels/gitinfo/...pass (the two packages consuming the go-github API)Co-authored-by: Copilot App 223556219+Copilot@users.noreply.github.com