Hello microverse - #1
Conversation
There was a problem hiding this comment.
Hello @jovasal 👋
CHANGES REQUIRED ♻️
Great work on the project 👏
You've done well so far in the project, However, there are a few you need to work on, to move to the next project. 💯
Highlights
- Good use of GitHub features ✔️
- Nice setup of linters 👍
Required Changes 🌵
- You made some impressive implementations which I must say is a job well done. However, there are a few features you missed or need to adjust.
- Kindly make sure your pull request summary is very descriptive. This is a highlight of all changes you've made in this branch and should be as detailed as possible to help not just a reviewer, but also you and your team when working together to know what changes were made at this milestone 👍 . Use this Link Template to see a detailed way to make a professional PR
_Check the comments for a detailed review
Optional suggestions
Every comment with the [OPTIONAL] prefix won't stop the approval of this PR. However, I strongly recommend you take them into account as they can make your code better. Some of them were simply missed by the previous reviewer and addressing them will really improve your application.
Feel free to leave any questions or comments in the PR thread if something is not 100% clear.
Please, remember to tag me in your question so I can receive the notification.
Please, do not open a new Pull Request for re-reviews. You should use the same Pull Request submitted for the first review, either valid or invalid unless it is requested otherwise.
As described in the Code reviews limits policy you have a limited number of reviews per project (check the exact number in your Dashboard). If you think that the code review was not fair, you can request a second opinion using this form.
|
|
||
| _NOTE: Copyright 2023, [JOHN ALONSO VASQUEZ SALCEDO] | ||
|
|
||
| <p align="right">(<a href="#readme-top">back to top</a>)</p> |
There was a problem hiding this comment.
- Kindly add the license file from the Template provided so that when this link is clicked, it leads to it. This is an important file for all your project going forward as regards ownership of your work 👍
There was a problem hiding this comment.
MIT.md is in my project now
| @@ -0,0 +1 @@ | |||
| This file should be ignored by git | |||
There was a problem hiding this comment.
- This file should ideally be ignored by git when you push your changes. The purpose of the
.gitignorefile is to ignore all files added to it, so it's not added to your repository. Kindly check your files changed, and make sure it ignored on this branch 👍
Instructions:
There was a problem hiding this comment.
I delete "This file should be ignored by git"
Also, Test.md is into .gitignore
|
|
||
| <div align="center"> | ||
| <!-- You are encouraged to replace this logo with your own! Otherwise you can also remove it. --> | ||
| <br/> |
There was a problem hiding this comment.
- As a comment/guide, this section should not be committed to your project. This makes your work look professional and have your codebase clean 👍
There was a problem hiding this comment.
Great!!
I deleted all comments as described before:
Microverse README Template
📗 Table of Contents
📖 [your_project_name]
This is my first project.
[your_project__name] is My-First-Project
🛠 Built With
Tech Stack
This project were made with HTML and CSS.
Client
Server
Key Features
Describe between 1-3 key features of the application.
- [key_feature_1]
Learning
- [key_feature_2]
Aplication
- [key_feature_3]
Develop
🚀 Live Demo
Demo is no requiered.
💻 Getting Started
This project is a develop reference gor beguiners
Prerequisites
In order to run this project you need:
<Knowledge in HTML and CSS
Setup
Clone this repository to your desired folder:
Example commands:
cd my-folder
git clone https://github.com/jovasal/My-First-Project.git👥 Authors
John Alonso Vasquez Salcedo
👤 Author1
- GitHub: @githubhandle
- Twitter: @twitterhandle
- LinkedIn: LinkedIn
🤝 Contributing
Thank you so much to Miroverse course
https://www.microverse.org/es/inicio
📝 License
This project is MIT licensed.
AbelG101
left a comment
AbelG101
left a comment
There was a problem hiding this comment.
Hi @jovasal 👋,
Great work on making the changes requested by a previous reviewer 👏
You've done well implementing some of the requested changes, but there are still some which aren't addressed yet.
Highlights
- Correct use of GitHub Flow ✔
- Well-structured files ✔
- All linter checks are passing ✔
- Descriptive PR title with a good summary ✔
Required Changes ♻️
- Check the comments under the review.
- You just have to make a few changes and you're on your way 🚀.
Optional suggestions
- N/A
Every comment with the [OPTIONAL] prefix won't stop the approval of this PR. However, I strongly recommend you take them into account as they can make your code better. Some of them were simply missed by the previous reviewer and addressing them will really improve your application.
Cheers and Happy coding!👏👏👏
Feel free to leave any questions or comments in the PR thread if something is not 100% clear.
Please, remember to tag me in your question so I can receive the notification.
Please, do not open a new Pull Request for re-reviews. You should use the same Pull Request submitted for the first review, either valid or invalid unless it is requested otherwise.
As described in the Code reviews limits policy you have a limited number of reviews per project (check the exact number in your Dashboard). If you think that the code review was not fair, you can request a second opinion using this form.
joel-kalema
left a comment
joel-kalema
left a comment
There was a problem hiding this comment.
Hi @jovasal
Your project is complete! There is nothing else to say other than... it's time to merge it 
Congratulations! 🎉
Highlights
Linters are passing 👍
The project is running successfully 👍
PR is well descriptive 👍
Optional suggestions
Every comment with the [OPTIONAL] prefix won't stop the approval of this PR. However, I strongly recommend you to take them into account as they can make your code better. Some of them were simply missed by the previous reviewer and addressing them will really improve your application.
Cheers and Happy coding!👏👏👏
Feel free to leave any questions or comments in the PR thread if something is not 100% clear.
Please, remember to tag me @joel-kalema in your question so I can receive the notification.
As described in the Code reviews limits policy you have a limited number of reviews per project (check the exact number in your Dashboard). If you think that the code review was not fair, you can request a second opinion using this form.
4 participants
This is my first project in Microverse with Linters and Github Flow