fix(ci): align workflow Node.js version with package engines - #2134
Open
MGPOCKY wants to merge 1 commit into
Open
fix(ci): align workflow Node.js version with package engines#2134MGPOCKY wants to merge 1 commit into
MGPOCKY wants to merge 1 commit into
Conversation
|
|
MGPOCKY
marked this pull request as ready for review
July 31, 2026 09:17
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
Package metadata declares
engines.node/volta.node/.nvmrcas8,10,12,14,16,18,20,22,24,26, but CI workflows still pinnode-versionto a mismatched value.That can make CI run on a runtime the project no longer supports (or skip the version the package actually targets).
What changed
Update the affected workflow
node-versionpins so they satisfy8,10,12,14,16,18,20,22,24,26(using26where a concrete pin is needed)..github/workflows/tests.ymlnode-version: [6.x]→node-version: [8.x]Test plan
engines.node/volta.node/.nvmrcis still8,10,12,14,16,18,20,22,24,26Found while auditing CI/package version consistency across popular repos.