docs(triage): 2026-07-06 sweep — #142–#147 (5 covered, 1 new: symlink resolver) - #150
Merged
Conversation
…ne new item Incremental upstream review. Backlog steady at 72 open; six new PRs #142-#147. Five already covered -> SKIP; one genuinely-new latent bug -> new action item. - NousResearch#142: 5 of 6 fixes are covered clusters (GEPA/DSPy-3.2 compat x3, validate-full). The 6th is real and new here: find_skill via Path.rglob('SKILL.md') skips symlinked skill dirs on Python <3.13 (skill_sources.py:63/67/80). Promoted to a CHERRY-PICK action item (recommended). - #143: our #102 — state.db read-only importer already shipped; only cross-platform discovery extras. SKIP. - #144/#145: Sunwo0u HSE sanitized evidence packets, report-only, no mechanism. SKIP. - #146: extraction cluster — our skill_text is a @Property over signature.instructions, so its 'dead input field' premise is upstream-only. SKIP. - #147: compat + material_diff reporting subsumed by our behavioral deploy gate. SKIP. Review-log entry + new action-item row + 2026-07-06 snapshot delta.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Incremental upstream PR review (continues
docs/upstream_pr_triage.md).Sweep result
Backlog steady at 72 open (6 opened, 6 closed since 2026-06-30). Six new PRs #142–#147. Five already covered → SKIP; one genuinely-new latent bug → new action item.
One new action item — symlink-aware skill resolver (from #142)
find_skilltraversal usesPath.rglob("SKILL.md")(evolution/core/skill_sources.py:63,67,80), which does not descend into symlinked skill directories on Python <3.13. A Hermes layout that symlinks user-installed skills into the framework tree would silently resolve "skill not found." Real latent bug in a path we own — recommend a small symlink-following fix (guarding against symlink cycles). Pending go-ahead; not implemented in this doc PR.Already covered → SKIP
reflection_lm,max_full_evals-only, 5-arg metric) +validate_allfull-text + one provider-specific.state.dbread-only importer (mode=ro) already shipped with JSON fallback. Only extras are cross-platform DB discovery (env override + Windows) — marginal here.skill_textis a@propertyoversignature.instructions, so its "dead input field" premise is upstream-only. Metric caveat moot (we useLLMJudge+ closed-loop).material_diffreporting idea is subsumed by our behavioral deploy gate (identical artifact → ~0 improvement → no deploy).Changes
Doc-only: 2026-07-06 review-log entry, new action-item row for the symlink resolver, snapshot delta.
(Upstream items referenced with fully-qualified
NousResearch/hermes-agent-self-evolution#NNN.)