feat(docker): add service discovery via tsbridge container labels - #201
Open
aareman wants to merge 1 commit into
Open
feat(docker): add service discovery via tsbridge container labels#201aareman wants to merge 1 commit into
aareman wants to merge 1 commit into
Conversation
Add ability to define services on the tsbridge container itself, enabling auto-discovery of matching containers even without tsbridge.enabled=true. This is useful for dynamically created containers (like Nextcloud AIO) where adding labels to service containers isn't possible. Changes: - Add parseServiceNames() to extract service names from tsbridge container labels - Add findContainersByNames() to discover containers by name - Modify Load() to merge services from both discovery mechanisms - Traditional discovery (tsbridge.enabled=true) takes precedence - Add comprehensive unit tests - Update documentation with examples and use cases Closes: docker-service-discovery
Author
|
I have been running this on a home-lab setup for 2 weeks and it has been working well. |
Author
|
Following up about this. Haven't had any issues on my home-lab setup. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add ability to define services on the tsbridge container itself, enabling auto-discovery of matching containers even without tsbridge.enabled=true.
This is useful for dynamically created containers (like Nextcloud AIO) where adding labels to service containers isn't possible.
Changes:
Closes: docker-service-discovery