feat(gateway): support If-None-Match wildcard - #7479
Open
ilcm96 wants to merge 8 commits into
Open
Conversation
Point the temporary fork replacement at the squashed, pushed MinIO feature commit used by the upstream pull request.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Add S3 conditional-write support for
If-None-Match: *to JuiceFS Gateway.RenameNoReplace412 Precondition Failedfor existing explicit markers and501 Not Implementedfor implicit POSIX directories that cannot yet be promoted atomicallyIf-None-Matchheader fieldsFixes #6460.
MinIO dependency
This PR depends on juicedata/minio#84.
The current
go.modreplacement intentionally points to the pushed feature commit in my MinIO fork so this PR and its CI can be tested before the MinIO PR is merged. After #84 is merged, I will update the replacement to the correspondinggithub.com/juicedata/miniocommit before this PR is merged.Verification
All verification was run in Docker:
The live JuiceFS Gateway checks also verified:
501without changing inode state or child data412If-None-Matchfields are combined correctly: an empty field followed by*returns412, while*followed by an ETag returns400