Skip to content

Minor refinements to options declaration#4

Open
leomayleomay wants to merge 2 commits into
juspay:mainfrom
leomayleomay:use-type-alias
Open

Minor refinements to options declaration#4
leomayleomay wants to merge 2 commits into
juspay:mainfrom
leomayleomay:use-type-alias

Conversation

@leomayleomay

@leomayleomay leomayleomay commented Jun 3, 2024

Copy link
Copy Markdown
  1. Use type alias featureType
  2. Fix the URL pointing to Just import

2. Fix the URL pointing to Just import

@srid srid left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

But I'll have to test this before merging (ideally after #5).

@leomayleomay

Copy link
Copy Markdown
Author

@srid indeed, I've added CI

@leomayleomay leomayleomay requested a review from srid June 4, 2024 23:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants