feat(app-server): add turn/start parity API#573
feat(app-server): add turn/start parity API#573cbusillo wants to merge 4 commits intojust-every:mainfrom
Conversation
Finish the thread/resume compatibility shim and add native model/list and review/start handlers to the local app-server compatibility layer.
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 20797cb6c0
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| let catalog_entry = match catalog.find_by_id(&thread_id).await { | ||
| Ok(entry) => entry, | ||
| Err(err) => { | ||
| let error = JSONRPCErrorError { | ||
| code: INTERNAL_ERROR_CODE, |
There was a problem hiding this comment.
ThreadResumeParams specifies that path takes precedence over thread_id, but this branch always calls catalog.find_by_id(&thread_id) first and fails immediately on lookup errors. If the session catalog is unreadable/corrupt, a valid explicit path resume request is rejected before the path is even tried, even though thread_id should be ignored in that mode.
Useful? React with 👍 / 👎.
| if let Ok(requested_conversation_id) = ConversationId::from_string(&thread_id) | ||
| && requested_conversation_id != conversation_id | ||
| { | ||
| self.resumed_conversation_aliases | ||
| .lock() |
There was a problem hiding this comment.
This alias insertion runs even when thread/resume was driven by an explicit path, where thread_id is supposed to be ignored. If the request carries a different valid thread id, that id is remapped to the newly resumed conversation and later operations (turn/start, review/start, interrupts, etc.) on the original thread id will be routed to the wrong thread via resolve_conversation_id_alias.
Useful? React with 👍 / 👎.
1 participant
Summary
turn/startDependency
just-every/code, this PR currently targetsmainand includes the parity commit until feat(app-server): add review and model parity APIs #570 landsTesting
cargo test -p code-app-server --quiet./build-fast.sh