fix(amazing-grace): simplify panel coordination, remove cache marker - #32
fix(amazing-grace): simplify panel coordination, remove cache marker#32kaaloo wants to merge 1 commit into
Conversation
Replace the renderedByStatusline cache-file coordination with direct
closePanel("amazing-grace") from the statusline mod. The cache approach
was racy: the marker could be overwritten by saveState before the panel
read it, and the write could fail if the cache file did not exist yet.
👾 Generated with [Letta Code](https://letta.com)
Co-Authored-By: Letta Code <noreply@letta.com>
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 064ac57b76
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| // Renders the ladder position and health below the statusline. A statusline | ||
| // mod that renders the same info inline can close this panel with | ||
| // letta.ui.closePanel("amazing-grace"). |
There was a problem hiding this comment.
On installations whose existing ~/.letta/mods/statusline.tsx follows the previously documented contract and only writes renderedByStatusline: true, upgrading this package now makes both the inline indicator and this panel render because the marker is ignored. The replacement closePanel call exists only as a comment here, and a repo-wide search finds no distributed statusline implementation that upgrades users to the new coordination mechanism, so retain the marker fallback or ship/document a compatible migration.
Useful? React with 👍 / 👎.
1 participant
Summary
renderedByStatuslinecache-file coordination from the amazing-grace panelletta.ui.closePanel("amazing-grace")saveStatebefore the panel read itTest plan
npm run checkinpackages/amazing-gracenpm run verifyinpackages/amazing-grace👾 Generated with Letta Code