core/config: resolve MY_CONFIG path before warning unrelatedness#486
Open
yutotakano wants to merge 1 commit into
Open
core/config: resolve MY_CONFIG path before warning unrelatedness#486yutotakano wants to merge 1 commit into
yutotakano wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR #336 added a warning for when the detected
my.configmodule is not in a subpath ofMY_CONFIG. This was to help diagnose bad setups.This warning is currently faulty. Because the paths aren't resolved before comparison, setting
MY_CONFIGto a relative value like./configwill fail the check despite the config module existing within the current working directory. (Using relative values for the env might be seen with a directory-sandboxed HPI setup, using something like direnv)The pull request resolves both paths used in the comparison to the absolute path. The problem described above is fixed, which I verified with a locally editable install.