chore: bump V8 to 15.0.206 - #13
Merged
Merged
Conversation
|
…c shim linux-arm64 (pointer-compression) on V8 15.0.206 (PR #13) failed: allocator_shim_default_dispatch_to_partition_alloc.cc:342: error: there are no arguments to 'memcpy' that depend on a template parameter, so a declaration of 'memcpy' must be available [-fpermissive] PA_UNSAFE_TODO(memcpy(new_ptr, address, copy_size)); note: 'memcpy' is defined in header '<cstring>'; this is probably fixable by adding '#include <cstring>' Run: https://github.com/kassane/libv8/actions/runs/26401418861/job/77714396376 V8 15.0.206 added AlignedRealloc / AlignedReallocUnchecked *template* member functions to PartitionAllocFunctionsInternal that call memcpy, but the TU never includes <cstring>. C++ two-phase name lookup requires a non-dependent name (memcpy) to be declared at template-definition time; gcc-14 (linux-arm64) enforces this and rejects it. clang (every other target) resolves memcpy transitively and is laxer, so only the gcc target trips. Same class as Patch 6 (gcc missing-include). The include is correct and harmless on every platform, so it's applied unconditionally — inserted after the `#include <malloc.h>` / `#endif` block so it lands outside the platform conditional and memcpy is declared regardless of the guard. partition_alloc is a gclient DEP populated by `gclient sync` before patch-v8.sh runs, so the file is present at patch time. Patch is sentinel-gated and idempotent, and short-circuits if a future V8 ships the include itself. Verified the anchor + insertion against a synthetic copy of the platform-gated malloc.h include block.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.